The glmark2 benchmark score went down (on Android with Pixel devices) when ANGLE changed VkSwapchainCreateInfoKHR::minImageCount from 3 down to 2, when using VK_PRESENT_MODE_MAILBOX_KHR. In experimenting, this was confirmed. This CL changes minImageCount back to 3. Vulkan spec issue #1671 was filed in order to understand whether this is a good/bad approach for other drivers/platforms. Test: glmark2 on Pixel2. Bug: angleproject: 3400 Change-Id: Ia4a72733eb648e4f53feeb8833b174d653fa5766 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610242 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| android | Loading commit data... | |
| doc/img | Loading commit data... | |
| fuchsia | Loading commit data... | |
| shaders | Loading commit data... | |
| win32 | Loading commit data... | |
| xcb | Loading commit data... | |
| BufferVk.cpp | Loading commit data... | |
| BufferVk.h | Loading commit data... | |
| CommandGraph.cpp | Loading commit data... | |
| CommandGraph.h | Loading commit data... | |
| CompilerVk.cpp | Loading commit data... | |
| CompilerVk.h | Loading commit data... | |
| ContextVk.cpp | Loading commit data... | |
| ContextVk.h | Loading commit data... | |
| DeviceVk.cpp | Loading commit data... | |
| DeviceVk.h | Loading commit data... | |
| DisplayVk.cpp | Loading commit data... | |
| DisplayVk.h | Loading commit data... | |
| FenceNVVk.cpp | Loading commit data... | |
| FenceNVVk.h | Loading commit data... | |
| FramebufferVk.cpp | Loading commit data... | |
| FramebufferVk.h | Loading commit data... | |
| GlslangWrapper.cpp | Loading commit data... | |
| GlslangWrapper.h | Loading commit data... | |
| ImageVk.cpp | Loading commit data... | |
| ImageVk.h | Loading commit data... | |
| MemoryObjectVk.cpp | Loading commit data... | |
| MemoryObjectVk.h | Loading commit data... | |
| ProgramPipelineVk.cpp | Loading commit data... | |
| ProgramPipelineVk.h | Loading commit data... | |
| ProgramVk.cpp | Loading commit data... | |
| ProgramVk.h | Loading commit data... | |
| QueryVk.cpp | Loading commit data... | |
| QueryVk.h | Loading commit data... | |
| README.md | Loading commit data... | |
| RenderTargetVk.cpp | Loading commit data... | |
| RenderTargetVk.h | Loading commit data... | |
| RenderbufferVk.cpp | Loading commit data... | |
| RenderbufferVk.h | Loading commit data... | |
| RendererVk.cpp | Loading commit data... | |
| RendererVk.h | Loading commit data... | |
| SamplerVk.cpp | Loading commit data... | |
| SamplerVk.h | Loading commit data... | |
| SecondaryCommandBuffer.cpp | Loading commit data... | |
| SecondaryCommandBuffer.h | Loading commit data... | |
| ShaderVk.cpp | Loading commit data... | |
| ShaderVk.h | Loading commit data... | |
| SurfaceVk.cpp | Loading commit data... | |
| SurfaceVk.h | Loading commit data... | |
| SyncVk.cpp | Loading commit data... | |
| SyncVk.h | Loading commit data... | |
| TextureVk.cpp | Loading commit data... | |
| TextureVk.h | Loading commit data... | |
| TransformFeedbackVk.cpp | Loading commit data... | |
| TransformFeedbackVk.h | Loading commit data... | |
| UtilsVk.cpp | Loading commit data... | |
| UtilsVk.h | Loading commit data... | |
| VertexArrayVk.cpp | Loading commit data... | |
| VertexArrayVk.h | Loading commit data... | |
| gen_vk_format_table.py | Loading commit data... | |
| gen_vk_internal_shaders.py | Loading commit data... | |
| gen_vk_mandatory_format_support_table.py | Loading commit data... | |
| vk_cache_utils.cpp | Loading commit data... | |
| vk_cache_utils.h | Loading commit data... | |
| vk_caps_utils.cpp | Loading commit data... | |
| vk_caps_utils.h | Loading commit data... | |
| vk_format_map.json | Loading commit data... | |
| vk_format_table_autogen.cpp | Loading commit data... | |
| vk_format_utils.cpp | Loading commit data... | |
| vk_format_utils.h | Loading commit data... | |
| vk_helpers.cpp | Loading commit data... | |
| vk_helpers.h | Loading commit data... | |
| vk_internal_shaders_autogen.cpp | Loading commit data... | |
| vk_internal_shaders_autogen.gni | Loading commit data... | |
| vk_internal_shaders_autogen.h | Loading commit data... | |
| vk_mandatory_format_support_data.json | Loading commit data... | |
| vk_mandatory_format_support_table_autogen.cpp | Loading commit data... | |
| vk_utils.cpp | Loading commit data... | |
| vk_utils.h | Loading commit data... | |
| vk_wrapper.h | Loading commit data... |