This CL contains two changes. One to how we print out GLboolean
values, and another to how we capture GLbooleans.
According to the spec, anything non-zero can be considered
GL_TRUE when setting state:
When the type of internal state is boolean, zero integer or
floating-point values are converted to FALSE and non-zero values
are converted to TRUE.
Dota Underlords is using 0xFF for GL_TRUE.
Before the change, this manifested as:
// logcat
glColorMask(context = 4, red = kUnknownGLenumString,
green = kUnknownGLenumString,
blue = kUnknownGLenumString,
alpha = GL_FALSE)
// trace
glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);
After:
// logcat
glColorMask(context = 4, red = 0x00FF,
green = 0x00FF,
blue = 0x00FF,
alpha = GL_FALSE)
// trace
glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);
Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by:
Tim Van Patten <timvp@google.com>
Reviewed-by:
Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| android | Loading commit data... | |
| build_overrides | Loading commit data... | |
| doc | Loading commit data... | |
| extensions | Loading commit data... | |
| gni | Loading commit data... | |
| include | Loading commit data... | |
| infra | Loading commit data... | |
| samples | Loading commit data... | |
| scripts | Loading commit data... | |
| src | Loading commit data... | |
| third_party | Loading commit data... | |
| tools | Loading commit data... | |
| util | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .gitattributes | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gn | Loading commit data... | |
| .style.yapf | Loading commit data... | |
| .vpython | Loading commit data... | |
| .vpython3 | Loading commit data... | |
| .yapfignore | Loading commit data... | |
| AUTHORS | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CONTRIBUTORS | Loading commit data... | |
| DEPS | Loading commit data... | |
| DIR_METADATA | Loading commit data... | |
| LICENSE | Loading commit data... | |
| OWNERS | Loading commit data... | |
| PRESUBMIT.py | Loading commit data... | |
| README.chromium | Loading commit data... | |
| README.md | Loading commit data... | |
| WATCHLISTS | Loading commit data... | |
| additional_readme_paths.json | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| dotfile_settings.gni | Loading commit data... |