It seems reasonable to validate the equality between stencilWriteMask and stencilBackWriteMask only by comparing the effective bits. An existing dEQP test[1] and a WebGL test[2] also use the max size of stencil bits for checking the stencil mask values. [1] StencilWriteMaskSeparateTestCase (gles3/functional/ es3fIntegerStateQueryTests.cpp) [2] https://www.khronos.org/registry/webgl/sdk/tests/conformance/state/ gl-get-calls.html (Search for "minimumRequiredStencilMask ") Change-Id: I68cefbe8a9f69c5a9ebcb30027a05581e3024add Reviewed-on: https://chromium-review.googlesource.com/302703Reviewed-by:Corentin Wallez <cwallez@chromium.org> Tested-by:
Jinyoung Hur <hurims@gmail.com> Commit-Queue: Jinyoung Hur <hurims@gmail.com> Tryjob-Request: Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| shaders | Loading commit data... | |
| Blit9.cpp | Loading commit data... | |
| Blit9.h | Loading commit data... | |
| Buffer9.cpp | Loading commit data... | |
| Buffer9.h | Loading commit data... | |
| DebugAnnotator9.cpp | Loading commit data... | |
| DebugAnnotator9.h | Loading commit data... | |
| Fence9.cpp | Loading commit data... | |
| Fence9.h | Loading commit data... | |
| Framebuffer9.cpp | Loading commit data... | |
| Framebuffer9.h | Loading commit data... | |
| Image9.cpp | Loading commit data... | |
| Image9.h | Loading commit data... | |
| IndexBuffer9.cpp | Loading commit data... | |
| IndexBuffer9.h | Loading commit data... | |
| Query9.cpp | Loading commit data... | |
| Query9.h | Loading commit data... | |
| RenderTarget9.cpp | Loading commit data... | |
| RenderTarget9.h | Loading commit data... | |
| Renderer9.cpp | Loading commit data... | |
| Renderer9.h | Loading commit data... | |
| ShaderCache.h | Loading commit data... | |
| ShaderExecutable9.cpp | Loading commit data... | |
| ShaderExecutable9.h | Loading commit data... | |
| SwapChain9.cpp | Loading commit data... | |
| SwapChain9.h | Loading commit data... | |
| TextureStorage9.cpp | Loading commit data... | |
| TextureStorage9.h | Loading commit data... | |
| VertexArray9.h | Loading commit data... | |
| VertexBuffer9.cpp | Loading commit data... | |
| VertexBuffer9.h | Loading commit data... | |
| VertexDeclarationCache.cpp | Loading commit data... | |
| VertexDeclarationCache.h | Loading commit data... | |
| formatutils9.cpp | Loading commit data... | |
| formatutils9.h | Loading commit data... | |
| renderer9_utils.cpp | Loading commit data... | |
| renderer9_utils.h | Loading commit data... | |
| vertexconversion.h | Loading commit data... |