Work around Gtest build failure caused by -Werror=unused-function. (#529)

We're propagating extra warning flags to the gtest build, which can cause it to fail. This patch prevents passing "-Wextra" to gtest, since the library itself doesn't test with that flag.

Work around Gtest build failure caused by -Werror=unused-function. (#529)
906749a4 · Eric · Dominic Hamon · 296ec569 · 906749a4
Commit 906749a4 authored Feb 12, 2018 by Eric Committed by Dominic Hamon Feb 12, 2018
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

HandleGTest.cmake cmake/HandleGTest.cmake +5 -0

No files found.
--- a/cmake/HandleGTest.cmake
+++ b/cmake/HandleGTest.cmake
@@ -23,6 +23,11 @@ macro(build_external_gtest)
  if ("${GTEST_BUILD_TYPE}" STREQUAL "COVERAGE")
    set(GTEST_BUILD_TYPE "DEBUG")
  endif()
+  # FIXME: Since 10/Feb/2017 the googletest trunk has had a bug where
+  # -Werror=unused-function fires during the build on OS X. This is a temporary
+  # workaround to keep our travis bots from failing. It should be removed
+  # once gtest is fixed.
+  list(APPEND GTEST_FLAGS "-Wno-unused-function")
  split_list(GTEST_FLAGS)
  ExternalProject_Add(googletest
      EXCLUDE_FROM_ALL ON