- 05 Apr, 2019 1 commit
-
-
Joseph Loser authored
Summary: - When google benchmark is used as a submodule in a parent projects whose min CMake version is 3.3.2 or later, the google benchmark `CMakeLists.txt` triggers a warning regarding CMake policy 0063: ``` CMake Warning (dev) at tests/googlebenchmark/src/CMakeLists.txt:19 (add_library): Policy CMP0063 is not set: Honor visibility properties for all target types. Run "cmake --help-policy CMP0063" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Target "benchmark" of type "STATIC_LIBRARY" has the following visibility properties set for CXX: CXX_VISIBILITY_PRESET VISIBILITY_INLINES_HIDDEN For compatibility CMake is not honoring them for this target. This warning is for project developers. Use -Wno-dev to suppress it. ``` - Set CMake Policy 0063 to NEW if the policy is available. This will not affect parent projects who include benchmark but do not have a CMake min version of 3.3.2 or later, i.e. when this policy is introduced.
-
- 28 Mar, 2019 2 commits
-
-
Dominic Hamon authored
-
Dominic Hamon authored
-
- 26 Mar, 2019 2 commits
-
-
Daniel Harvey authored
* Add FIXME in multiple_ranges_test.cc * Improve handling of large bounds in AddRange. Due to breaking the loop too early, AddRange would miss a final multplier of 'mult' that was within the numeric range of T. * Enable negative values for Range argument Fixes #762. * Try to fix build of benchmark_gtest * Try some more to fix build * Attempt to fix format macros * Attempt to resolve format errors for mingw32 * Review feedback Put unit tests in benchmark::internal namespace Fix error reporting in multiple_ranges_test.cc
-
BaaMeow authored
* [JSON] add threads and repetitions to the json output, for better ide… [Tests] explicitly check for thread == 1 [Tests] specifically mark all repetition checks [JSON] add repetition_index reporting, but only for non-aggregates (i… * [Formatting] Be very, very explicit about pointer alignment so clang-format can not put pointers/references on the wrong side of arguments. [Benchmark::Run] Make sure to use explanatory sentinel variable rather than a magic number. * Do not pass redundant information
-
- 19 Mar, 2019 1 commit
-
-
Michael Tesch authored
-
- 17 Mar, 2019 2 commits
-
-
Roman Lebedev authored
It broke because the libc++ is being built as part of *this* build, with old gcc+libstdc++ (4.8?), but LLVM is preparing to switch to C++14, and gcc+libstdc++ <5 are soft-deprecated. Just the gcc update doesn't cut it, clang still uses old libstdc++.
-
Daniel Harvey authored
Created BenchmarkName class which holds the full benchmark name and allows specifying and retrieving different components of the name (e.g. ARGS, THREADS etc.) Fixes #730.
-
- 06 Mar, 2019 2 commits
-
-
Roman Lebedev authored
Refs #779.
-
Roman Lebedev authored
Run into this by accident while writing benchmark to validate the fix for https://bugs.llvm.org/show_bug.cgi?id=40965 Fixes #779.
-
- 28 Feb, 2019 1 commit
-
-
Jilin Zhou authored
- On qnx platform, cpu and cache info is stored in a syspage struct which is different from other OS platform. - The fix has been verified on an aarch64 target running qnx 7.0. Fixes #774
-
- 19 Feb, 2019 2 commits
-
-
Jilin Zhou authored
Since googletest already supports x-compilation for QNX, it is nice to have google benchmark support it too. Fixes #766
-
Wes McKinney authored
-
- 04 Feb, 2019 1 commit
-
-
Roman Lebedev authored
-
- 01 Feb, 2019 1 commit
-
-
Daniel Kraft authored
Since pthread is required at least for GCC (according to the documentation), this should be reflected by the pkg-config file. The same is, for instance, also done by the gflags library: https://github.com/gflags/gflags/blob/1005485222e8b0feff822c5723ddcaa5abadc01a/cmake/package.pc.in#L13
-
- 15 Jan, 2019 1 commit
-
-
Dominic Hamon authored
-
- 13 Jan, 2019 1 commit
-
-
Andriy Berestovskyy authored
Commit 17a012d7 added a newline to the str, so the line built from str.length() is one character longer than it should be.
-
- 03 Jan, 2019 1 commit
-
-
Michael "Croydon" Keck authored
-
- 30 Dec, 2018 1 commit
-
-
Reid Kleckner authored
If this policy isn't set, CMake emits a large warning when project() is called from a cmake subdirectory. This came up when the benchmark library was added to the LLVM build, and it was reported in https://llvm.org/PR38874. This patch was the fix I applied locally to fix the issue, and I wanted to send it upstream.
-
- 14 Dec, 2018 1 commit
-
-
Eric authored
Some benchmarks are particularly sensitive and they run in less than a nanosecond. In order for the console reporter to provide meaningful output for such benchmarks it needs to be able to display the times using more resolution than a single nanosecond. This patch changes the console reporter to print at least three significant digits for all results. Unlike the initial attempt, this patch does not align the decimal point.
-
- 13 Dec, 2018 2 commits
-
-
Roman Lebedev authored
As pointed out in IRC, these are not documented.
-
Dominic Hamon authored
It should now match reality.
-
- 11 Dec, 2018 1 commit
-
-
Jatin Chaudhary authored
* Adding Host Name and test * Addressing Review Comments * Adding Test for JSON Reporter * Adding HOST_NAME_MAX for MacOS systems * Adding Explaination for MacOS HOST_NAME_MAX Addition * Addressing Peer Review Comments * Adding codecvt in windows header guard * Changing name SystemInfo and adding empty message incase host name fetch fails * Adding Comment on Struct SystemInfo
-
- 10 Dec, 2018 2 commits
-
-
Tobias Ulvgård authored
-
Cyrille authored
Unit-tests fail to build due to the following errors: /home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5: required from here /home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (lhs == rhs) { ~~~~^~~~~~ Fixes #741
-
- 07 Dec, 2018 1 commit
-
-
Jusufadis Bakamovic authored
-
- 30 Nov, 2018 1 commit
-
-
Eric authored
std::tmpnam is deprecated and its use is discouraged. For our purposes in the tests, we really just need a file name which is unlikely to exist. This patch converts the tests to using a dummy random file name generator, which should hopefully avoid name conflicts.
-
- 28 Nov, 2018 1 commit
-
-
Roman Lebedev authored
-
- 27 Nov, 2018 1 commit
-
-
Roman Lebedev authored
Fixes #714.
-
- 26 Nov, 2018 1 commit
-
-
Roman Lebedev authored
Used that example as a snippet, and it took a moment to notice what needed to be changed to make it compile..
-
- 22 Nov, 2018 1 commit
-
-
Denis Glazachev authored
-
- 13 Nov, 2018 3 commits
-
-
Dominic Hamon authored
-
Dominic Hamon authored
-
- 02 Nov, 2018 1 commit
-
-
Kirill Bobyrev authored
This is the copy of patch proposed to LLVM's copy of benchmark via https://reviews.llvm.org/D52998.
-
- 21 Oct, 2018 1 commit
-
-
Anton Gladky authored
s390 has another line structure for processor-field. It should be differently parsed.
-
- 18 Oct, 2018 3 commits
-
-
Roman Lebedev authored
It is incorrect to say that an aggregate is computed over run's iterations, because those iterations already got averaged. Similarly, if there are N repetitions with 1 iterations each, an aggregate will be computed over N measurements, not 1. Thus it is best to simply use the count of separate reports. Fixes #586.
-
Roman Lebedev authored
It is better to let the RunBenchmarks(), report() decide whether to actually *only* output aggregates or not, depending on whether there are actually aggregates. It's subtle indeed. Previously, `BenchmarkRunner()` always said that "if there are no repetitions, then you should never output only the repetitions". And the `report()` simply assumed that the `report_aggregates_only` bool it received makes sense, and simply used it. Now, the logic is the same, but the blame has shifted. `BenchmarkRunner()` always propagates what those benchmarks would have wanted to happen wrt the aggregates. And the `report()` lambda has to actually consider both the `report_aggregates_only` bool, and it's meaningfulness. To put it in the context of the patch series - if the repetition count was `1`, but `*_report_aggregates_only` was set to `true`, and we capture each iteration separately, then we will compute the aggregates, but then output everything, both the iteration, and aggregates, despite `*_report_aggregates_only` being set to `true`.
-
Roman Lebedev authored
That is the real purpose of that bool. A follow-up change will make it consider something else other than repetitions.
-
- 13 Oct, 2018 1 commit
-
-
Olzhas Kaiyrakhmet authored
If benchmark added as cmake subproject, HandleGTest throws an error as does return absolute source dir. Change it to , so it will be refering to it's own source dir. Also see PR #703.
-