1. 20 May, 2021 1 commit
  2. 19 May, 2021 1 commit
  3. 11 May, 2021 1 commit
    • Support -Wsuggest-override (#1059) · 7d0d9061
      Guillaume Chatelet authored
      * Support -Wsuggest-override
      
      google/benchmark is C++11 compatible but doesn't use the `override` keyword.
      Projects using google/benchmark with enabled `-Wsuggest-override` and `-Werror` will fail to compile.
      
      * Add -Wsuggest-override cxx flag
      
      * Revert unrelated formatting
      
      * Revert unrelated formatting, take 2
      
      * Revert unrelated formatting, take 3
      
      * Disable -Wsuggest-override when compiling tests, gtest does not handle it yet
      Co-authored-by: 's avatarDominic Hamon <dominichamon@users.noreply.github.com>
  4. 10 May, 2021 2 commits
  5. 07 May, 2021 4 commits
    • remove done TODOs · 0852c79f
      Dominic Hamon authored
    • add g++-6 to ubuntu-14.04 (#1144) · 551a21ba
      Dominic Hamon authored
      * add g++-6 to ubuntu-14.04
      
      * fix syntax
      
      * fix yamllint errors for build-and-test
      
      * fix 'add-apt-repository' command not found
      
      * make 'run tests' explicit
      
      * enable testing and run both release and debug
      
      * oops
    • Add ubuntu-14.04 build and test workflow (#1131) · a53b8853
      Dominic Hamon authored
      * Add ubuntu-14.04 build and test workflow
      
      * avoid '.' in job name
      
      * no need for fail fast
      
      * fix workflow syntax
      
      * install some stuff
      
      * better compiler installations
      
      * update before install
      
      * just say yes
      
      * trying to match up some paths
      
      * Difference between runner and github context in container?
      
      * Try some judicious logging
      
      * cmake 3.5+ required
      
      * specific compiler versions
      
      * need git for googletest
      
      * Disable testing on old compilers
      
      * disable testing properly
  6. 06 May, 2021 3 commits
  7. 05 May, 2021 1 commit
  8. 04 May, 2021 1 commit
  9. 30 Apr, 2021 1 commit
    • Add multiple compiler support to build-and-test workflow (#1128) · ba9a763d
      Dominic Hamon authored
      * Add 32-bit build support to build-and-test
      
      * attempt different yaml multiline string format
      
      * syntax fixes to yaml
      
      * switch to getting alternative compilers working
      
      * remove done TODO
      
      * trying to separate out windows
      
      * oops, typo.
      
      * add TODOs for missing builds wrt travis
  10. 28 Apr, 2021 2 commits
    • enable markdown rendering on github pages · 64cb55e9
      Dominic Hamon authored
    • Support optional, user-directed collection of performance counters (#1114) · 376ebc26
      Mircea Trofin authored
      * Support optional, user-directed collection of performance counters
      
      The patch allows an engineer wishing to drill into the root causes
      of a regression, for example. Currently, only single threaded runs
      are supported. The feature is a build-time opt in, and then a runtime
      opt in.
      
      The engineer may run the benchmark executable, passing a list of
      performance counter names (using libpfm's naming scheme) at the
      command line. The counter values will then be collected and reported
      back as UserCounters.
      
      This is different from #240 in that it is a benchmark user opt-in, and
      the counter collection is transparent to the benchmark.
      
      Currently, this is only supported on platforms where libpfm is
      supported.
      
      libpfm: http://perfmon2.sourceforge.net/
      
      * 'Use' values param in Snapshot when BENCHMARK_OS_WINDOWS
      
      This is to avoid unused parameter warning-as-error
      
      * Added missing include for <vector> in perf_counters.cc
      
      * Moved doc to docs
      
      * Added license blurbs
  11. 27 Apr, 2021 2 commits
  12. 26 Apr, 2021 2 commits
  13. 24 Apr, 2021 2 commits
  14. 23 Apr, 2021 1 commit
    • [sysinfo] Fix CPU Frequency reading on AMD Ryzen CPU's (#1117) · c05843a9
      Roman Lebedev authored
      Currently, i get:
      ```
      Run on (32 X 7326.56 MHz CPU s)
      CPU Caches:
        L1 Data 32 KiB (x16)
        L1 Instruction 32 KiB (x16)
        L2 Unified 512 KiB (x16)
        L3 Unified 32768 KiB (x2)
      ```
      which seems mostly right, except that the frequency is rather bogus.
      Yes, i guess the CPU could theoretically achieve that,
      but i have 3.6GHz configured, and scaling disabled.
      So we clearly read the wrong thing.
      
      With this fix, i now get the expected
      ```
      Run on (32 X 3598.53 MHz CPU s)
      CPU Caches:
        L1 Data 32 KiB (x16)
        L1 Instruction 32 KiB (x16)
        L2 Unified 512 KiB (x16)
        L3 Unified 32768 KiB (x2)
      ```
  15. 20 Apr, 2021 1 commit
    • Use fewer ramp up repetitions when KeepRunningBatch is used (#1113) · 69054ae5
      Matt Armstrong authored
      Use the benchmark's reported iteration count when estimating
      iterations for the next repetition, rather than the requested
      iteration count.  When the benchmark uses KeepRunningBatch the actual
      iteration count can be larger than the one the runner requested.
      
      Prior to this fix the runner was underestimating the next iteration
      count, sometimes significantly so.  Consider the case of a benchmark
      using a batch size of 1024.  Prior to this change, the benchmark
      runner would attempt iteration counts 1, 10, 100 and 1000, yet the
      benchmark itself would do the same amount of work each time: a single
      batch of 1024 iterations.  The discrepancy could also contribute to
      estimation errors once the benchmark time reached 10% of the target.
      For example, if the very first batch of 1024 iterations reached 10% of
      benchmark_min_min time, the runner would attempt to scale that to 100%
      from a basis of one iteration rather than 1024.
      
      This bug was particularly noticeable in benchmarks with large batch
      sizes, especially when the benchmark also had slow set up or tear down
      phases.
      
      With this fix in place it is possible to use KeepRunningBatch to
      achieve a kind of "minimum iteration count" feature by using a larger
      fixed batch size.  For example, a benchmark may build a map of 500K
      elements and test a "find" operation.  There is no point in running
      "find" just 1, 10, 100, etc., times.  The benchmark can now pick a
      batch size of something like 10K, and the runner will arrive at the
      final max iteration count with in noticeably fewer repetitions.
  16. 19 Apr, 2021 2 commits
  17. 12 Apr, 2021 1 commit
  18. 09 Apr, 2021 4 commits
    • Shrink the tz_offset size to 41. (#1110) · 07578d82
      Chris Lalancette authored
      When building with gcc TSan on, and in Debug mode, we see a warning
      like:
      
      benchmark/src/timers.cc: In function ‘std::string benchmark::LocalDateTimeString()’:
      src/timers.cc:241:15: warning: ‘char* strncat(char*, const char*, size_t)’ output may be truncated copying 108 bytes from a string of length 127 [-Wstringop-truncation]
        241 |   std::strncat(storage, tz_offset, sizeof(storage) - timestamp_len - 1);
            |   ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      While this is essentially a false positive (we never expect
      the number of bytes in tz_offset to be too large), the compiler can't
      actually tell that.  Shrink the size of tz_offset to a smaller, but still safe
      size to eliminate this warning.
      Signed-off-by: 's avatarChris Lalancette <clalancette@openrobotics.org>
    • fix minor typo · 5a77a6d8
      Dominic Hamon authored
    • fix minor typo · b8084e50
      Dominic Hamon authored
  19. 30 Mar, 2021 1 commit
    • Implement custom benchmark name (#1107) · 5e387e7d
      Tobias Schmidt authored
      * Implement custom benchmark name
      
      The benchmark's name can be changed using the Name() function
      which internally uses SetName().
      
      * Update AUTHORS and CONTRIBUTORS
      
      * Describe new feature in README
      
      * Move new name function up
      
      Fixes #1106
  20. 08 Mar, 2021 1 commit
  21. 05 Mar, 2021 2 commits
  22. 22 Feb, 2021 2 commits
  23. 14 Feb, 2021 1 commit
  24. 12 Feb, 2021 1 commit