- 06 Mar, 2019 2 commits
-
-
Roman Lebedev authored
Refs #779.
-
Roman Lebedev authored
Run into this by accident while writing benchmark to validate the fix for https://bugs.llvm.org/show_bug.cgi?id=40965 Fixes #779.
-
- 28 Feb, 2019 1 commit
-
-
Jilin Zhou authored
- On qnx platform, cpu and cache info is stored in a syspage struct which is different from other OS platform. - The fix has been verified on an aarch64 target running qnx 7.0. Fixes #774
-
- 19 Feb, 2019 2 commits
-
-
Jilin Zhou authored
Since googletest already supports x-compilation for QNX, it is nice to have google benchmark support it too. Fixes #766
-
Wes McKinney authored
-
- 04 Feb, 2019 1 commit
-
-
Roman Lebedev authored
-
- 01 Feb, 2019 1 commit
-
-
Daniel Kraft authored
Since pthread is required at least for GCC (according to the documentation), this should be reflected by the pkg-config file. The same is, for instance, also done by the gflags library: https://github.com/gflags/gflags/blob/1005485222e8b0feff822c5723ddcaa5abadc01a/cmake/package.pc.in#L13
-
- 15 Jan, 2019 1 commit
-
-
Dominic Hamon authored
-
- 13 Jan, 2019 1 commit
-
-
Andriy Berestovskyy authored
Commit 17a012d7 added a newline to the str, so the line built from str.length() is one character longer than it should be.
-
- 03 Jan, 2019 1 commit
-
-
Michael "Croydon" Keck authored
-
- 30 Dec, 2018 1 commit
-
-
Reid Kleckner authored
If this policy isn't set, CMake emits a large warning when project() is called from a cmake subdirectory. This came up when the benchmark library was added to the LLVM build, and it was reported in https://llvm.org/PR38874. This patch was the fix I applied locally to fix the issue, and I wanted to send it upstream.
-
- 14 Dec, 2018 1 commit
-
-
Eric authored
Some benchmarks are particularly sensitive and they run in less than a nanosecond. In order for the console reporter to provide meaningful output for such benchmarks it needs to be able to display the times using more resolution than a single nanosecond. This patch changes the console reporter to print at least three significant digits for all results. Unlike the initial attempt, this patch does not align the decimal point.
-
- 13 Dec, 2018 2 commits
-
-
Roman Lebedev authored
As pointed out in IRC, these are not documented.
-
Dominic Hamon authored
It should now match reality.
-
- 11 Dec, 2018 1 commit
-
-
Jatin Chaudhary authored
* Adding Host Name and test * Addressing Review Comments * Adding Test for JSON Reporter * Adding HOST_NAME_MAX for MacOS systems * Adding Explaination for MacOS HOST_NAME_MAX Addition * Addressing Peer Review Comments * Adding codecvt in windows header guard * Changing name SystemInfo and adding empty message incase host name fetch fails * Adding Comment on Struct SystemInfo
-
- 10 Dec, 2018 2 commits
-
-
Tobias Ulvgård authored
-
Cyrille authored
Unit-tests fail to build due to the following errors: /home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5: required from here /home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (lhs == rhs) { ~~~~^~~~~~ Fixes #741
-
- 07 Dec, 2018 1 commit
-
-
Jusufadis Bakamovic authored
-
- 30 Nov, 2018 1 commit
-
-
Eric authored
std::tmpnam is deprecated and its use is discouraged. For our purposes in the tests, we really just need a file name which is unlikely to exist. This patch converts the tests to using a dummy random file name generator, which should hopefully avoid name conflicts.
-
- 28 Nov, 2018 1 commit
-
-
Roman Lebedev authored
-
- 27 Nov, 2018 1 commit
-
-
Roman Lebedev authored
Fixes #714.
-
- 26 Nov, 2018 1 commit
-
-
Roman Lebedev authored
Used that example as a snippet, and it took a moment to notice what needed to be changed to make it compile..
-
- 22 Nov, 2018 1 commit
-
-
Denis Glazachev authored
-
- 13 Nov, 2018 3 commits
-
-
Dominic Hamon authored
-
Dominic Hamon authored
-
- 02 Nov, 2018 1 commit
-
-
Kirill Bobyrev authored
This is the copy of patch proposed to LLVM's copy of benchmark via https://reviews.llvm.org/D52998.
-
- 21 Oct, 2018 1 commit
-
-
Anton Gladky authored
s390 has another line structure for processor-field. It should be differently parsed.
-
- 18 Oct, 2018 3 commits
-
-
Roman Lebedev authored
It is incorrect to say that an aggregate is computed over run's iterations, because those iterations already got averaged. Similarly, if there are N repetitions with 1 iterations each, an aggregate will be computed over N measurements, not 1. Thus it is best to simply use the count of separate reports. Fixes #586.
-
Roman Lebedev authored
It is better to let the RunBenchmarks(), report() decide whether to actually *only* output aggregates or not, depending on whether there are actually aggregates. It's subtle indeed. Previously, `BenchmarkRunner()` always said that "if there are no repetitions, then you should never output only the repetitions". And the `report()` simply assumed that the `report_aggregates_only` bool it received makes sense, and simply used it. Now, the logic is the same, but the blame has shifted. `BenchmarkRunner()` always propagates what those benchmarks would have wanted to happen wrt the aggregates. And the `report()` lambda has to actually consider both the `report_aggregates_only` bool, and it's meaningfulness. To put it in the context of the patch series - if the repetition count was `1`, but `*_report_aggregates_only` was set to `true`, and we capture each iteration separately, then we will compute the aggregates, but then output everything, both the iteration, and aggregates, despite `*_report_aggregates_only` being set to `true`.
-
Roman Lebedev authored
That is the real purpose of that bool. A follow-up change will make it consider something else other than repetitions.
-
- 13 Oct, 2018 3 commits
-
-
Olzhas Kaiyrakhmet authored
If benchmark added as cmake subproject, HandleGTest throws an error as does return absolute source dir. Change it to , so it will be refering to it's own source dir. Also see PR #703.
-
Olzhas Kaiyrakhmet authored
* Fix SOURCE_DIR in HandleGTest.cmake If benchmark added as cmake subproject, HandleGTest throws an error as does return absolute source dir. Change it to , so it will be refering to it's own source dir.
-
- 08 Oct, 2018 1 commit
-
-
Ilya A. Kriveshko authored
As prevously written, "--benchmark_color=auto" was treated as true, because IsTruthyFlagValue("auto") returned true. The fix is to rely on IsColorTerminal test only if the flag value is "auto", and fall back to IsTruthyFlagValue otherwise. I also integrated force_no_color check into the same block.
-
- 05 Oct, 2018 1 commit
-
-
Gregorio Litenstein authored
For several versions now, CMake by default refers to macOS’ Clang as AppleClang instead of just Clang, which would fail STREQUAL. Fixed by changing it to MATCHES.
-
- 01 Oct, 2018 2 commits
-
-
Roman Lebedev authored
Ok, so, i'm still trying to get to the state when it will be a trivial change to report all the separate iterations. The old code (LHS of the diff) was rather convoluted i'd say. I have tried to refactor it a bit into *small* logical chunks, with proper comments. As far as i can tell, i preserved the intent of the code, what it was doing before. The road forward still isn't clear, but i'm quite sure it's not with the old code :)
-
Victor Costan authored
-
- 28 Sep, 2018 1 commit
-
-
Dominic Hamon authored
The State constructor should not be part of the public API. Adding a utility method to BenchmarkInstance allows us to avoid leaking the RunInThread method into the public API.
-
- 26 Sep, 2018 1 commit
-
-
Roman Lebedev authored
See https://github.com/google/googletest/pull/1815 Fixes #689.
-