When building with gcc TSan on, and in Debug mode, we see a warning
like:
benchmark/src/timers.cc: In function ‘std::string benchmark::LocalDateTimeString()’:
src/timers.cc:241:15: warning: ‘char* strncat(char*, const char*, size_t)’ output may be truncated copying 108 bytes from a string of length 127 [-Wstringop-truncation]
241 | std::strncat(storage, tz_offset, sizeof(storage) - timestamp_len - 1);
| ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
While this is essentially a false positive (we never expect
the number of bytes in tz_offset to be too large), the compiler can't
actually tell that. Shrink the size of tz_offset to a smaller, but still safe
size to eliminate this warning.
Signed-off-by:
Chris Lalancette <clalancette@openrobotics.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| CMakeLists.txt | Loading commit data... | |
| arraysize.h | Loading commit data... | |
| benchmark.cc | Loading commit data... | |
| benchmark_api_internal.cc | Loading commit data... | |
| benchmark_api_internal.h | Loading commit data... | |
| benchmark_main.cc | Loading commit data... | |
| benchmark_name.cc | Loading commit data... | |
| benchmark_register.cc | Loading commit data... | |
| benchmark_register.h | Loading commit data... | |
| benchmark_runner.cc | Loading commit data... | |
| benchmark_runner.h | Loading commit data... | |
| check.h | Loading commit data... | |
| colorprint.cc | Loading commit data... | |
| colorprint.h | Loading commit data... | |
| commandlineflags.cc | Loading commit data... | |
| commandlineflags.h | Loading commit data... | |
| complexity.cc | Loading commit data... | |
| complexity.h | Loading commit data... | |
| console_reporter.cc | Loading commit data... | |
| counter.cc | Loading commit data... | |
| counter.h | Loading commit data... | |
| csv_reporter.cc | Loading commit data... | |
| cycleclock.h | Loading commit data... | |
| internal_macros.h | Loading commit data... | |
| json_reporter.cc | Loading commit data... | |
| log.h | Loading commit data... | |
| mutex.h | Loading commit data... | |
| re.h | Loading commit data... | |
| reporter.cc | Loading commit data... | |
| sleep.cc | Loading commit data... | |
| sleep.h | Loading commit data... | |
| statistics.cc | Loading commit data... | |
| statistics.h | Loading commit data... | |
| string_util.cc | Loading commit data... | |
| string_util.h | Loading commit data... | |
| sysinfo.cc | Loading commit data... | |
| thread_manager.h | Loading commit data... | |
| thread_timer.h | Loading commit data... | |
| timers.cc | Loading commit data... | |
| timers.h | Loading commit data... |