It is better to let the RunBenchmarks(), report() decide whether to actually *only* output aggregates or not, depending on whether there are actually aggregates. It's subtle indeed. Previously, `BenchmarkRunner()` always said that "if there are no repetitions, then you should never output only the repetitions". And the `report()` simply assumed that the `report_aggregates_only` bool it received makes sense, and simply used it. Now, the logic is the same, but the blame has shifted. `BenchmarkRunner()` always propagates what those benchmarks would have wanted to happen wrt the aggregates. And the `report()` lambda has to actually consider both the `report_aggregates_only` bool, and it's meaningfulness. To put it in the context of the patch series - if the repetition count was `1`, but `*_report_aggregates_only` was set to `true`, and we capture each iteration separately, then we will compute the aggregates, but then output everything, both the iteration, and aggregates, despite `*_report_aggregates_only` being set to `true`.
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| CMakeLists.txt | Loading commit data... | |
| arraysize.h | Loading commit data... | |
| benchmark.cc | Loading commit data... | |
| benchmark_api_internal.cc | Loading commit data... | |
| benchmark_api_internal.h | Loading commit data... | |
| benchmark_main.cc | Loading commit data... | |
| benchmark_register.cc | Loading commit data... | |
| benchmark_register.h | Loading commit data... | |
| benchmark_runner.cc | Loading commit data... | |
| benchmark_runner.h | Loading commit data... | |
| check.h | Loading commit data... | |
| colorprint.cc | Loading commit data... | |
| colorprint.h | Loading commit data... | |
| commandlineflags.cc | Loading commit data... | |
| commandlineflags.h | Loading commit data... | |
| complexity.cc | Loading commit data... | |
| complexity.h | Loading commit data... | |
| console_reporter.cc | Loading commit data... | |
| counter.cc | Loading commit data... | |
| counter.h | Loading commit data... | |
| csv_reporter.cc | Loading commit data... | |
| cycleclock.h | Loading commit data... | |
| internal_macros.h | Loading commit data... | |
| json_reporter.cc | Loading commit data... | |
| log.h | Loading commit data... | |
| mutex.h | Loading commit data... | |
| re.h | Loading commit data... | |
| reporter.cc | Loading commit data... | |
| sleep.cc | Loading commit data... | |
| sleep.h | Loading commit data... | |
| statistics.cc | Loading commit data... | |
| statistics.h | Loading commit data... | |
| string_util.cc | Loading commit data... | |
| string_util.h | Loading commit data... | |
| sysinfo.cc | Loading commit data... | |
| thread_manager.h | Loading commit data... | |
| thread_timer.h | Loading commit data... | |
| timers.cc | Loading commit data... | |
| timers.h | Loading commit data... |