This is a shameless rip-off of https://github.com/google/benchmark/pull/646 I did promise to look into why that proposed PR was producing so much worse assembly, and so i finally did. The reason is - that diff changes `size_t` (unsigned) to `int64_t` (signed). There is this nice little `assert`: https://github.com/google/benchmark/blob/7a1c37028359ca9d386d719a6ad527743cf1b753/include/benchmark/benchmark.h#L744 It ensures that we didn't magically decide to advance our iterator when we should have finished benchmarking. When `cached_` was unsigned, the `assert` was `cached_ UGT 0`. But we only ever get to that `assert` if `cached_ NE 0`, and naturally if `cached_` is not `0`, then it is bigger than `0`, so the `assert` is tautological, and gets folded away. But now that `cached_` became signed, the assert became `cached_ SGT 0`. And we still only know that `cached_ NE 0`, so the assert can't be optimized out, or at least it doesn't currently. Regardless of whether or not that is a bug in itself, that particular diff would have regressed the normal 64-bit systems, by halving the maximal iteration space (since we go from unsigned counter to signed one, of the same bit-width), which seems like a bug. And just so it happens, fixing *this* bug, fixes the other bug. This produces fully (bit-by-bit) identical state_assembly_test.s The filecheck change is actually needed regardless of this patch, else this test does not pass for me even without this diff.
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| AssemblyTests.cmake | Loading commit data... | |
| BUILD | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| basic_test.cc | Loading commit data... | |
| benchmark_gtest.cc | Loading commit data... | |
| benchmark_name_gtest.cc | Loading commit data... | |
| benchmark_test.cc | Loading commit data... | |
| clobber_memory_assembly_test.cc | Loading commit data... | |
| commandlineflags_gtest.cc | Loading commit data... | |
| complexity_test.cc | Loading commit data... | |
| cxx03_test.cc | Loading commit data... | |
| diagnostics_test.cc | Loading commit data... | |
| display_aggregates_only_test.cc | Loading commit data... | |
| donotoptimize_assembly_test.cc | Loading commit data... | |
| donotoptimize_test.cc | Loading commit data... | |
| filter_test.cc | Loading commit data... | |
| fixture_test.cc | Loading commit data... | |
| internal_threading_test.cc | Loading commit data... | |
| link_main_test.cc | Loading commit data... | |
| map_test.cc | Loading commit data... | |
| memory_manager_test.cc | Loading commit data... | |
| multiple_ranges_test.cc | Loading commit data... | |
| options_test.cc | Loading commit data... | |
| output_test.h | Loading commit data... | |
| output_test_helper.cc | Loading commit data... | |
| register_benchmark_test.cc | Loading commit data... | |
| report_aggregates_only_test.cc | Loading commit data... | |
| reporter_output_test.cc | Loading commit data... | |
| skip_with_error_test.cc | Loading commit data... | |
| state_assembly_test.cc | Loading commit data... | |
| statistics_gtest.cc | Loading commit data... | |
| string_util_gtest.cc | Loading commit data... | |
| templated_fixture_test.cc | Loading commit data... | |
| user_counters_tabular_test.cc | Loading commit data... | |
| user_counters_test.cc | Loading commit data... | |
| user_counters_thousands_test.cc | Loading commit data... |