json_serializer: Disable exceptions

Define `JSON_NOEXCEPTION` to avoid raising exceptions. Exceptions are usually disabled for Google projects (https://google.github.io/styleguide/cppguide.html#Exceptions). Also pass `false` to the `allow_exceptions` parameter of `nlohmann::json::parse()`. Issue identified by @kuafuwang in #26.

json_serializer: Disable exceptions
aeb66147 · Ben Clayton · 773f0dff · aeb66147
Commit aeb66147 authored May 26, 2020 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

json_serializer.cpp src/json_serializer.cpp +5 -1

No files found.
--- a/src/json_serializer.cpp
+++ b/src/json_serializer.cpp
@@ -14,6 +14,9 @@

 #include "json_serializer.h"

+// Disable JSON exceptions. We should be guarding against any exceptions being
+// fired in this file.
+#define JSON_NOEXCEPTION 1
 #include <nlohmann/json.hpp>

 namespace {
@@ -45,7 +48,8 @@ namespace dap {
 namespace json {

 Deserializer::Deserializer(const std::string& str)
-    : json(new nlohmann::json(nlohmann::json::parse(str))), ownsJson(true) {}
+    : json(new nlohmann::json(nlohmann::json::parse(str, nullptr, false))),
+      ownsJson(true) {}

 Deserializer::Deserializer(const nlohmann::json* json)
    : json(json), ownsJson(false) {}