Nonfunctional: minor: use std::array for per-set shifts, fix warning.

Two unrelated, minor tweaks: (1) Use std::array for shiftBindingForSet. Now matches shiftBinding. (2) Add parens in shouldFlatten() to make compiler warning happy.

Nonfunctional: minor: use std::array for per-set shifts, fix warning.
2915da30 · LoopDawg · 573cc9e9 · 2915da30 · 2915da30
Commit 2915da30 authored Oct 20, 2017 by LoopDawg
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 4 deletions

localintermediate.h glslang/MachineIndependent/localintermediate.h +1 -2

hlslParseHelper.cpp hlsl/hlslParseHelper.cpp +2 -2

No files found.
--- a/glslang/MachineIndependent/localintermediate.h
+++ b/glslang/MachineIndependent/localintermediate.h
@@ -677,8 +677,7 @@ protected:
    std::array<unsigned int, EResCount> shiftBinding;

    // Per-descriptor-set shift values
-    typedef std::map<int, int> TDescriptorSetShift;
-    TDescriptorSetShift shiftBindingForSet[EResCount];
+    std::array<std::map<int, int>, EResCount>  shiftBindingForSet;

    std::vector<std::string> resourceSetBinding;
    bool autoMapBindings;

--- a/hlsl/hlslParseHelper.cpp
+++ b/hlsl/hlslParseHelper.cpp
@@ -1157,8 +1157,8 @@ bool HlslParseContext::shouldFlatten(const TType& type, TStorageQualifier qualif
    case EvqVaryingOut:
        return type.isStruct() || type.isArray();
    case EvqUniform:
-        return type.isArray() && intermediate.getFlattenUniformArrays() && topLevel ||
-               type.isStruct() && type.containsOpaque();
+        return (type.isArray() && intermediate.getFlattenUniformArrays() && topLevel) ||
+               (type.isStruct() && type.containsOpaque());
    default:
        return type.isStruct() && type.containsOpaque();
    };