Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
glslang
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
glslang
Commits
437911af
Commit
437911af
authored
Oct 23, 2017
by
Aaron Muir Hamilton
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
GLSL: Check for implicit inner dimension in array of atomic_uint.
parent
9cfc1551
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
26 additions
and
1 deletion
+26
-1
implicitInnerAtomicUint.frag.out
Test/baseResults/implicitInnerAtomicUint.frag.out
+21
-0
implicitInnerAtomicUint.frag
Test/implicitInnerAtomicUint.frag
+3
-0
ParseHelper.cpp
glslang/MachineIndependent/ParseHelper.cpp
+1
-1
AST.FromFile.cpp
gtests/AST.FromFile.cpp
+1
-0
No files found.
Test/baseResults/implicitInnerAtomicUint.frag.out
0 → 100644
View file @
437911af
implicitInnerAtomicUint.frag
ERROR: 0:2: '[]' : only outermost dimension of an array of arrays can be implicitly sized
ERROR: 0:2: 'atomic_uint' : array must be explicitly sized
ERROR: 2 compilation errors. No code generated.
Shader version: 460
ERROR: node is still EOpNull!
0:? Linker Objects
0:? 'c' (layout( binding=0 offset=0) uniform 1-element array of implicitly-sized array of atomic_uint)
Linked fragment stage:
ERROR: Linking fragment stage: Missing entry point: Each stage requires one entry point
Shader version: 460
ERROR: node is still EOpNull!
0:? Linker Objects
0:? 'c' (layout( binding=0 offset=0) uniform 1-element array of implicitly-sized array of atomic_uint)
Test/implicitInnerAtomicUint.frag
0 → 100644
View file @
437911af
#version 460
layout
(
binding
=
0
)
uniform
atomic_uint
c
[
1
][];
\ No newline at end of file
glslang/MachineIndependent/ParseHelper.cpp
View file @
437911af
...
...
@@ -4863,7 +4863,7 @@ void TParseContext::fixOffset(const TSourceLoc& loc, TSymbol& symbol)
// Check for overlap
int
numOffsets
=
4
;
if
(
symbol
.
getType
().
isArray
())
{
if
(
symbol
.
getType
().
isExplicitlySizedArray
())
if
(
symbol
.
getType
().
isExplicitlySizedArray
()
&&
!
symbol
.
getType
().
getArraySizes
()
->
isInnerImplicit
()
)
numOffsets
*=
symbol
.
getType
().
getCumulativeArraySize
();
else
{
// "It is a compile-time error to declare an unsized array of atomic_uint."
...
...
gtests/AST.FromFile.cpp
View file @
437911af
...
...
@@ -159,6 +159,7 @@ INSTANTIATE_TEST_CASE_P(
"460.vert"
,
"dce.frag"
,
"atomic_uint.frag"
,
"implicitInnerAtomicUint.frag"
,
"aggOps.frag"
,
"always-discard.frag"
,
"always-discard2.frag"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment