Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
glslang
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
glslang
Commits
46e07313
Commit
46e07313
authored
Apr 24, 2018
by
John Kessenich
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
GLSL/Vulkan: Warn about arrays of arrays of resources that need bindings.
Initial way of addressing #1362.
parent
b4cb70fc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
0 deletions
+10
-0
spv.AofA.frag.out
Test/baseResults/spv.AofA.frag.out
+2
-0
ParseHelper.cpp
glslang/MachineIndependent/ParseHelper.cpp
+8
-0
No files found.
Test/baseResults/spv.AofA.frag.out
View file @
46e07313
spv.AofA.frag
WARNING: 0:6: '[][]' : Generating SPIR-V array-of-arrays, but Vulkan only supports single array level for this resource
// Module Version 10000
// Generated by (magic number): 80006
// Id's are bound by 104
...
...
glslang/MachineIndependent/ParseHelper.cpp
View file @
46e07313
...
...
@@ -4791,6 +4791,14 @@ void TParseContext::layoutTypeCheck(const TSourceLoc& loc, const TType& type)
}
}
// some things can't have arrays of arrays
if
(
type
.
isArrayOfArrays
())
{
if
(
spvVersion
.
vulkan
>
0
)
{
if
(
type
.
isOpaque
()
||
(
type
.
getQualifier
().
isUniformOrBuffer
()
&&
type
.
getBasicType
()
==
EbtBlock
))
warn
(
loc
,
"Generating SPIR-V array-of-arrays, but Vulkan only supports single array level for this resource"
,
"[][]"
,
""
);
}
}
// "The offset qualifier can only be used on block members of blocks..."
if
(
qualifier
.
hasOffset
())
{
if
(
type
.
getBasicType
()
==
EbtBlock
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment