SPV: Change the key of extBuiltinMap to std::string

Using const char* is not a good choice. We assume strings are always from spv::E_SPV_XXX definitions. However, it is not the case. We can store the name strings of extended intruction set in local variables.

SPV: Change the key of extBuiltinMap to std::string
77fe62f4 · Rex Xu · 51d672b8 · 77fe62f4
Commit 77fe62f4 authored Feb 26, 2021 by Rex Xu
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

GlslangToSpv.cpp SPIRV/GlslangToSpv.cpp +1 -1

No files found.
--- a/SPIRV/GlslangToSpv.cpp
+++ b/SPIRV/GlslangToSpv.cpp
@@ -255,7 +255,7 @@ protected:
    bool nanMinMaxClamp;               // true if use NMin/NMax/NClamp instead of FMin/FMax/FClamp
    spv::Id stdBuiltins;
    spv::Id nonSemanticDebugPrintf;
-    std::unordered_map<const char*, spv::Id> extBuiltinMap;
+    std::unordered_map<std::string, spv::Id> extBuiltinMap;

    std::unordered_map<long long, spv::Id> symbolValues;
    std::unordered_set<long long> rValueParameters;  // set of formal function parameters passed as rValues,