Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
glslang
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
glslang
Commits
b3859343
Unverified
Commit
b3859343
authored
Apr 14, 2021
by
Greg Fischer
Committed by
GitHub
Apr 14, 2021
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2602 from jeremy-lunarg/hayes-2514
Issue error when declaration rule fails
parents
e7e4a8ee
4b900778
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
2 deletions
+5
-2
hlsl.includeNegative.vert.out
Test/baseResults/hlsl.includeNegative.vert.out
+2
-1
hlslGrammar.cpp
glslang/HLSL/hlslGrammar.cpp
+3
-1
No files found.
Test/baseResults/hlsl.includeNegative.vert.out
View file @
b3859343
...
@@ -3,8 +3,9 @@ ERROR: ./foo.h:1: '#error' : should not be included
...
@@ -3,8 +3,9 @@ ERROR: ./foo.h:1: '#error' : should not be included
ERROR: ./inc2/../foo.h:1: '#error' : should not be included
ERROR: ./inc2/../foo.h:1: '#error' : should not be included
ERROR: ./parentBad:3: '#error' : bad parent
ERROR: ./parentBad:3: '#error' : bad parent
ERROR: hlsl.includeNegative.vert:7: '#error' : in main
ERROR: hlsl.includeNegative.vert:7: '#error' : in main
ERROR: hlsl.includeNegative.vert:6: 'declaration' : Expected
hlsl.includeNegative.vert(8): error at column 0, HLSL parsing failed.
hlsl.includeNegative.vert(8): error at column 0, HLSL parsing failed.
ERROR:
5
compilation errors. No code generated.
ERROR:
6
compilation errors. No code generated.
SPIR-V is not generated for failed compile or link
SPIR-V is not generated for failed compile or link
glslang/HLSL/hlslGrammar.cpp
View file @
b3859343
...
@@ -161,8 +161,10 @@ bool HlslGrammar::acceptDeclarationList(TIntermNode*& nodeList)
...
@@ -161,8 +161,10 @@ bool HlslGrammar::acceptDeclarationList(TIntermNode*& nodeList)
return
true
;
return
true
;
// declaration
// declaration
if
(
!
acceptDeclaration
(
nodeList
))
if
(
!
acceptDeclaration
(
nodeList
))
{
expected
(
"declaration"
);
return
false
;
return
false
;
}
}
while
(
true
);
}
while
(
true
);
return
true
;
return
true
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment