Use std::string for TBD/missing functionality reporting.

We can have multiple instances of the same string, so comparing const char* is not guaranteed working. Fixed the failure on VS 2013 with Debug build.

Use std::string for TBD/missing functionality reporting.
cb3236d9 · Lei Zhang · f36d6e35 · cb3236d9 · cb3236d9
Commit cb3236d9 authored May 10, 2016 by Lei Zhang
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

Logger.cpp SPIRV/Logger.cpp +2 -2

Logger.h SPIRV/Logger.h +4 -4

No files found.
--- a/SPIRV/Logger.cpp
+++ b/SPIRV/Logger.cpp
@@ -40,13 +40,13 @@
 namespace spv {
-void SpvBuildLogger::tbdFunctionality(const char* f)
+void SpvBuildLogger::tbdFunctionality(const std::string& f)
 {
    if (std::find(std::begin(tbdFeatures), std::end(tbdFeatures), f) == std::end(tbdFeatures))
        tbdFeatures.push_back(f);
 }
-void SpvBuildLogger::missingFunctionality(const char* f)
+void SpvBuildLogger::missingFunctionality(const std::string& f)
 {
    if (std::find(std::begin(missingFeatures), std::end(missingFeatures), f) == std::end(missingFeatures))
        missingFeatures.push_back(f);

--- a/SPIRV/Logger.h
+++ b/SPIRV/Logger.h
@@ -48,9 +48,9 @@ public:
    SpvBuildLogger(const SpvBuildLogger&) = delete;
    // Registers a TBD functionality.
-    void tbdFunctionality(const char* f);
+    void tbdFunctionality(const std::string& f);
    // Registers a missing functionality.
-    void missingFunctionality(const char* f);
+    void missingFunctionality(const std::string& f);
    // Logs a warning.
    void warning(const std::string& w) { warnings.push_back(w); }
@@ -62,8 +62,8 @@ public:
    std::string getAllMessages() const;
 private:
-    std::vector<const char*> tbdFeatures;
+    std::vector<std::string> tbdFeatures;
-    std::vector<const char*> missingFeatures;
+    std::vector<std::string> missingFeatures;
    std::vector<std::string> warnings;
    std::vector<std::string> errors;
 };