Commit d4f48b8a by John Kessenich Committed by GitHub

Merge pull request #527 from steve-lunarg/array-flattening-fix

HLSL: Restrict uniform array flattening to sampler and texture arrays
parents 074ced3e bc9b7656
......@@ -941,7 +941,7 @@ void usage()
" explicit bindings.\n"
" --amb synonym for --auto-map-bindings\n"
"\n"
" --flatten-uniform-arrays flatten uniform array references to scalars\n"
" --flatten-uniform-arrays flatten uniform texture & sampler arrays to scalars\n"
" --fua synonym for --flatten-uniform-arrays\n"
);
......
......@@ -736,7 +736,9 @@ bool HlslParseContext::shouldFlattenUniform(const TType& type) const
return type.isArray() &&
intermediate.getFlattenUniformArrays() &&
qualifier == EvqUniform;
qualifier == EvqUniform &&
// Testing the EbtSampler basic type covers samplers and textures
type.getBasicType() == EbtSampler;
}
void HlslParseContext::flatten(const TSourceLoc& loc, const TVariable& variable)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment