Constant.cpp Floating point divide by zero

Constant.cpp will throw a floating point divide by zero if floating point exceptions are enabled in Win32 causing the program to crash. This fix manually checks the right-hand argument of the division and sets appropriate Infinity, Negative Infinity, or NAN as if the floating point exceptions were disabled.

Constant.cpp Floating point divide by zero
e826286f · Haydn Trigg · GitHub · 0b964b3c · e826286f
Unverified Commit e826286f authored Jun 29, 2018 by Haydn Trigg Committed by GitHub Jun 29, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 21 additions and 1 deletion

Constant.cpp glslang/MachineIndependent/Constant.cpp +21 -1

No files found.
--- a/glslang/MachineIndependent/Constant.cpp
+++ b/glslang/MachineIndependent/Constant.cpp
@@ -179,7 +179,27 @@ TIntermTyped* TIntermConstantUnion::fold(TOperator op, const TIntermTyped* right
            case EbtDouble:
            case EbtFloat:
            case EbtFloat16:
-                newConstArray[i].setDConst(leftUnionArray[i].getDConst() / rightUnionArray[i].getDConst());
+                {
+                    auto right = rightUnionArray[i].getDConst();
+                    auto left = leftUnionArray[i].getDConst();
+                    if (right)
+                    {
+                        newConstArray[i].setDConst(left / right);
+                    }
+                    else if (left > 0)
+                    {
+                        newConstArray[i].setDConst((double)INFINITY);
+                    }
+                    else if (left < 0)
+                    {
+                        newConstArray[i].setDConst((double)-INFINITY);
+                    }
+                    else
+                    {
+                        newConstArray[i].setDConst((double)NAN);
+                    }
+                }
                break;
            case EbtInt8:
                if (rightUnionArray[i] == (signed char)0)