1. 30 Jun, 2020 5 commits
    • CMake: break up glslang into smaller static libs · b8c3386e
      Ben Clayton authored
      Add `GenericCodeGen` and `MachineIndependent` static library targets.
      Privately import both of these into the `glslang` target.
      Privately import `MachineIndependent` into the  `SPIRV` target.
      
      This is done to break the dependency of `libglslang.so` non-public APIs from `libspirv.so`,
      which will become problematic once `glslang` hides its non-public symbols.
      
      | File                      | Before     |     After  |
      |---------------------------|-----------:|-----------:|
      | `libGenericCodeGen.a`     |  -         |   `527716` |
      | `libglslang.a`            | `68175944` |   `512938` |
      | `libHLSL.a`               |     `1428` |     `1428` |
      | `libMachineIndependent.a` |  -         | `67132202` |
      | `libOGLCompiler.a`        |    `75908` |    `75908` |
      | `libOSDependent.a`        |    `23768` |    `23768` |
      | `libSPIRV.a`              | `15710210` | `15710210` |
      | `libSPVRemapper.a`        |  `3250894` |  `3250894` |
      
      | File                                    | Before     |     After  |
      |-----------------------------------------|-----------:|-----------:|
      | `libglslang-default-resource-limits.so` |   `117032` |   `117032` |
      | `libglslang.so`                         | `22380688` | `22368216` |
      | `libHLSL.so`                            |     `7520` |     `7520` |
      | `libOGLCompiler.a`                      |    `75908` |    `75908` |
      | `libOSDependent.a`                      |    `23768` |    `23768` |
      | `libSPIRV.so`                           |  `7288336` | `28151016` |
      | `libSPVRemapper.so`                     |  `1940208` |  `1940208` |
      
      Issues: #2283, #1484
    • Merge pull request #2297 from ben-clayton/fpic · 8f4251a7
      John Kessenich authored
      CMake: Compile with -fPIC when building SOs
    • Merge pull request #2296 from ben-clayton/err-unresolved · 90f1d6ab
      John Kessenich authored
      CMake: Error on unresolved symbols
    • Merge pull request #2295 from ben-clayton/rm-old-kokoro-cfgs · dca47063
      John Kessenich authored
      Remove root kokoro/linux-*-cmake configs
    • Merge pull request #2292 from proydakov/gcc-unused-parameter · 2b6a18bd
      John Kessenich authored
      Fixed GCC -Wunused-parameter in hlslParseables.cpp.
  2. 29 Jun, 2020 5 commits
    • Fixed GCC -Wunused-parameter in hlslParseables.cpp. · f6e34463
      Evgeny Proydakov authored
      Warnings before fix:
      
      [3/7] Building CXX object glslang/CMakeFiles/glslang.dir/HLSL/hlslParseables.cpp.o
      ../glslang/HLSL/hlslParseables.cpp: In function ‘bool {anonymous}::IsValid(const char*, char, char, char, char, int, int)’:
      ../glslang/HLSL/hlslParseables.cpp:334:45: warning: unused parameter ‘retOrder’ [-Wunused-parameter]
        334 | inline bool IsValid(const char* cname, char retOrder, char retType, char argOrder, char argType, int dim0, int dim1)
            |                                        ~~~~~^~~~~~~~
      ../glslang/HLSL/hlslParseables.cpp:334:60: warning: unused parameter ‘retType’ [-Wunused-parameter]
        334 | inline bool IsValid(const char* cname, char retOrder, char retType, char argOrder, char argType, int dim0, int dim1)
            |                                                       ~~~~~^~~~~~~
      ../glslang/HLSL/hlslParseables.cpp:334:89: warning: unused parameter ‘argType’ [-Wunused-parameter]
        334 | inline bool IsValid(const char* cname, char retOrder, char retType, char argOrder, char argType, int dim0, int dim1)
            |                                                                                    ~~~~~^~~~~~~
      ../glslang/HLSL/hlslParseables.cpp:334:112: warning: unused parameter ‘dim1’ [-Wunused-parameter]
        334 | inline bool IsValid(const char* cname, char retOrder, char retType, char argOrder, char argType, int dim0, int dim1)
            |                                                                                                            ~~~~^~~~
    • CMake: Compile with -fPIC when building SOs · 981e1276
      Ben Clayton authored
      Without this embedding static libraries into shared libraries may result in link time errors.
      
      Issue: #2283
    • CMake: Error on unresolved symbols · 1fee6072
      Ben Clayton authored
      Issue: #1484
    • Remove root kokoro/linux-*-cmake configs · 08bc7cf5
      Ben Clayton authored
      These have been superseded by the `static` and `shared` variants in the respective subdirectories.
      
      Issue: #2283
    • Merge pull request #2286 from ben-clayton/kokoro-static-shared · 27e915ed
      John Kessenich authored
      Kokoro: Split linux cmake cfgs into static/shared
  3. 28 Jun, 2020 1 commit
  4. 26 Jun, 2020 2 commits
  5. 24 Jun, 2020 2 commits
  6. 23 Jun, 2020 1 commit
    • Fixed msvc 2019 nmake compiler warnings with RTTI. · b90adef9
      Evgeny Proydakov authored
      By default cmake generates cxx_flags with `/GR` parameter.
      I updated CMAKE_CXX_FLAGS string and replaced `/GR` -> `/GR-`
      
      How to reproduce:
      
      Visual Studio 2019 x64 command port
      
      mkdir build-msvc2019
      cd build-msvc2019
      cmake -G"NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=install ..
      nmake
      
      COMPILATION BEFORE:
      
      Scanning dependencies of target OSDependent
      [  1%] Building CXX object glslang/OSDependent/Windows/CMakeFiles/OSDependent.dir/ossource.cpp.obj
      cl : Command line warning D9025 : overriding '/GR' with '/GR-'
      ossource.cpp
      [  3%] Linking CXX static library OSDependent.lib
      [  3%] Built target OSDependent
      Scanning dependencies of target OGLCompiler
      [  4%] Building CXX object OGLCompilersDLL/CMakeFiles/OGLCompiler.dir/InitializeDll.cpp.obj
      cl : Command line warning D9025 : overriding '/GR' with '/GR-'
      InitializeDll.cpp
      [  6%] Linking CXX static library OGLCompiler.lib
      [  6%] Built target OGLCompiler
      Scanning dependencies of target glslang
      [  7%] Building CXX object glslang/CMakeFiles/glslang.dir/MachineIndependent/glslang_tab.cpp.obj
      cl : Command line warning D9025 : overriding '/GR' with '/GR-'
      glslang_tab.cpp
      [  9%] Building CXX object glslang/CMakeFiles/glslang.dir/MachineIndependent/attribute.cpp.obj
      cl : Command line warning D9025 : overriding '/GR' with '/GR-'
      
      FLAGS BEFORE:
      
      -- CMAKE_C_FLAGS:   /DWIN32 /D_WINDOWS /W3
      -- CMAKE_CXX_FLAGS: /DWIN32 /D_WINDOWS /W3 /GR /EHsc
      -- CMAKE_CXX_FLAGS_DEBUG:   /MDd /Zi /Ob0 /Od /RTC1
      -- CMAKE_CXX_FLAGS_RELEASE: /MD /O2 /Ob2 /DNDEBUG
      
      COMPILATION AFTER:
      
      [  1%] Building CXX object glslang/OSDependent/Windows/CMakeFiles/OSDependent.dir/ossource.cpp.obj
      ossource.cpp
      [  3%] Linking CXX static library OSDependent.lib
      [  3%] Built target OSDependent
      [  4%] Building CXX object OGLCompilersDLL/CMakeFiles/OGLCompiler.dir/InitializeDll.cpp.obj
      InitializeDll.cpp
      [  6%] Linking CXX static library OGLCompiler.lib
      [  6%] Built target OGLCompiler
      [  7%] Building CXX object glslang/CMakeFiles/glslang.dir/MachineIndependent/glslang_tab.cpp.obj
      glslang_tab.cpp
      [  9%] Building CXX object glslang/CMakeFiles/glslang.dir/MachineIndependent/attribute.cpp.obj
      
      FLAGS AFTER:
      
      -- CMAKE_C_FLAGS:   /DWIN32 /D_WINDOWS /W3
      -- CMAKE_CXX_FLAGS: /DWIN32 /D_WINDOWS /W3 /GR- /EHsc
      -- CMAKE_CXX_FLAGS_DEBUG:   /MDd /Zi /Ob0 /Od /RTC1
      -- CMAKE_CXX_FLAGS_RELEASE: /MD /O2 /Ob2 /DNDEBUG
  7. 22 Jun, 2020 7 commits
  8. 19 Jun, 2020 3 commits
  9. 18 Jun, 2020 1 commit
  10. 16 Jun, 2020 7 commits
  11. 15 Jun, 2020 5 commits
  12. 11 Jun, 2020 1 commit