Skip to content

G
googletest
Commit 28041f64 by David Benjamin
Options

Restore GTEST_ATTRIBUTE_PRINTF_ on ColoredPrintf

This fixes build issues with GoogleTest when built with -Wformat-nonliteral and unblocks updating GoogleTest in BoringSSL. It was added in 53c478d6, which caught some bugs. Then it was moved to the header and accidentally dropped in 482ac6ee.
parent 389cb68b
Showing with 2 additions and 1 deletion
googletest/src/gtest.cc
...@@ -3269,7 +3269,8 @@ bool ShouldUseColor(bool stdout_is_tty) { ...@@ -3269,7 +3269,8 @@ bool ShouldUseColor(bool stdout_is_tty) {
// This routine must actually emit the characters rather than return a string // This routine must actually emit the characters rather than return a string
// that would be colored when printed, as can be done on Linux. // that would be colored when printed, as can be done on Linux.
static void ColoredPrintf(GTestColor color, const char* fmt, ...) { GTEST_ATTRIBUTE_PRINTF_(2, 3)
static void ColoredPrintf(GTestColor color, const char *fmt, ...) {
va_list args; va_list args;
va_start(args, fmt); va_start(args, fmt);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment