Use std::addressof to instead of plain '&'.

Otherwise the code won't compile if the '&' operater is overloaded and return something that cannot be casted to void *.

Use std::addressof to instead of plain '&'.
2fc23831 · Chaoran Yang · 52998153 · 2fc23831
Commit 2fc23831 authored May 12, 2019 by Chaoran Yang
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

gtest-printers.h googletest/include/gtest/gtest-printers.h +2 -2

No files found.
--- a/googletest/include/gtest/gtest-printers.h
+++ b/googletest/include/gtest/gtest-printers.h
@@ -152,8 +152,8 @@ class TypeWithoutFormatter {
  // This default version is called when kTypeKind is kOtherType.
  static void PrintValue(const T& value, ::std::ostream* os) {
    PrintBytesInObjectTo(static_cast<const unsigned char*>(
-                             reinterpret_cast<const void*>(&value)),
+                             reinterpret_cast<const void*>(
-                         sizeof(value), os);
+                                 std::addressof(value))), sizeof(value), os);
  }
 };