Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
googletest
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
googletest
Commits
4c25e2b8
Commit
4c25e2b8
authored
Oct 16, 2019
by
Abseil Team
Committed by
Andy Soffer
Oct 16, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Googletest export
Remove a test case rendered obsolete by disallowing empty argument for INSTANTIATE_TEST_SUITE_P. Remove the code that it was testing. PiperOrigin-RevId: 275040108
parent
9e466f1e
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
18 deletions
+4
-18
gtest-param-util.h
googletest/include/gtest/internal/gtest-param-util.h
+1
-4
googletest-output-test-golden-lin.txt
googletest/test/googletest-output-test-golden-lin.txt
+3
-6
googletest-output-test_.cc
googletest/test/googletest-output-test_.cc
+0
-8
No files found.
googletest/include/gtest/internal/gtest-param-util.h
View file @
4c25e2b8
...
...
@@ -565,10 +565,7 @@ class ParameterizedTestSuiteInfo : public ParameterizedTestSuiteInfoBase {
test_param_names
.
insert
(
param_name
);
if
(
!
test_info
->
test_base_name
.
empty
())
{
test_name_stream
<<
test_info
->
test_base_name
<<
"/"
;
}
test_name_stream
<<
param_name
;
test_name_stream
<<
test_info
->
test_base_name
<<
"/"
<<
param_name
;
MakeAndRegisterTestInfo
(
test_suite_name
.
c_str
(),
test_name_stream
.
GetString
().
c_str
(),
nullptr
,
// No type parameter.
...
...
googletest/test/googletest-output-test-golden-lin.txt
View file @
4c25e2b8
...
...
@@ -12,7 +12,7 @@ Expected equality of these values:
3
Stack trace: (omitted)
[0;32m[==========] [mRunning 8
5 tests from 40
test suites.
[0;32m[==========] [mRunning 8
4 tests from 39
test suites.
[0;32m[----------] [mGlobal test environment set-up.
FooEnvironment::SetUp() called.
BarEnvironment::SetUp() called.
...
...
@@ -966,9 +966,6 @@ Expected equality of these values:
Stack trace: (omitted)
[0;31m[ FAILED ] [mPrintingFailingParams/FailingParamTest.Fails/0, where GetParam() = 2
[0;32m[----------] [m1 test from All/EmptyBasenameParamInst
[0;32m[ RUN ] [mAll/EmptyBasenameParamInst.Passes/0
[0;32m[ OK ] [mAll/EmptyBasenameParamInst.Passes/0
[0;32m[----------] [m2 tests from PrintingStrings/ParamTest
[0;32m[ RUN ] [mPrintingStrings/ParamTest.Success/a
[0;32m[ OK ] [mPrintingStrings/ParamTest.Success/a
...
...
@@ -995,8 +992,8 @@ Failed
Expected fatal failure.
Stack trace: (omitted)
[0;32m[==========] [m8
5 tests from 40
test suites ran.
[0;32m[ PASSED ] [m3
1
tests.
[0;32m[==========] [m8
4 tests from 39
test suites ran.
[0;32m[ PASSED ] [m3
0
tests.
[0;31m[ FAILED ] [m54 tests, listed below:
[0;31m[ FAILED ] [mNonfatalFailureTest.EscapesStringOperands
[0;31m[ FAILED ] [mNonfatalFailureTest.DiffForLongStrings
...
...
googletest/test/googletest-output-test_.cc
View file @
4c25e2b8
...
...
@@ -96,14 +96,6 @@ INSTANTIATE_TEST_SUITE_P(PrintingFailingParams,
FailingParamTest
,
testing
::
Values
(
2
));
// Tests that an empty value for the test suite basename yields just
// the test name without any prior /
class
EmptyBasenameParamInst
:
public
testing
::
TestWithParam
<
int
>
{};
TEST_P
(
EmptyBasenameParamInst
,
Passes
)
{
EXPECT_EQ
(
1
,
GetParam
());
}
INSTANTIATE_TEST_SUITE_P
(
All
,
EmptyBasenameParamInst
,
testing
::
Values
(
1
));
static
const
char
kGoldenString
[]
=
"
\"
Line
\0
1
\"\n
Line 2"
;
TEST
(
NonfatalFailureTest
,
EscapesStringOperands
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment