Googletest export

Launder buffer before reference In GCC, directly casting the Buffer reference to another type results in strict-aliasing violation errors. This launders the reference using an intermediate pointer prior to creating the new reference. PiperOrigin-RevId: 350809323

Googletest export
50ce5201 · Abseil Team · Derek Mauro · c13c27a5 · 50ce5201
Commit 50ce5201 authored Jan 08, 2021 by Abseil Team Committed by Derek Mauro Jan 13, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

gtest-matchers.h googletest/include/gtest/gtest-matchers.h +5 -1

No files found.
--- a/googletest/include/gtest/gtest-matchers.h
+++ b/googletest/include/gtest/gtest-matchers.h
@@ -421,7 +421,11 @@ class MatcherBase : private MatcherDescriberInterface {
  template <typename M, bool = IsInlined<M>()>
  struct ValuePolicy {
    static const M& Get(const MatcherBase& m) {
-      return reinterpret_cast<const M&>(m.buffer_);
+      // When inlined along with Init, need to be explicit to avoid violating
+      // strict aliasing rules.
+      const M *ptr = static_cast<const M*>(
+          static_cast<const void*>(&m.buffer_));
+      return *ptr;
    }
    static void Init(MatcherBase& m, M impl) {
      ::new (static_cast<void*>(&m.buffer_)) M(impl);