Makes List a random-access data structure. This simplifies the implementation…

include/gtest/gtest.h

@@ -434,13 +434,14 @@ class TestResult {
   TimeInMillis elapsed_time() const { return elapsed_time_; }
 
   // Returns the i-th test part result among all the results. i can range
-  // from 0 to test_property_count() - 1. If i is not in that range, returns
-  // NULL.
-  const TestPartResult* GetTestPartResult(int i) const;
+  // from 0 to test_property_count() - 1. If i is not in that range, aborts
+  // the program.
+  const TestPartResult& GetTestPartResult(int i) const;
 
   // Returns the i-th test property. i can range from 0 to
-  // test_property_count() - 1. If i is not in that range, returns NULL.
-  const TestProperty* GetTestProperty(int i) const;
+  // test_property_count() - 1. If i is not in that range, aborts the
+  // program.
+  const TestProperty& GetTestProperty(int i) const;
 
  private:
   friend class DefaultGlobalTestPartResultReporter;

include/gtest/internal/gtest-internal.h

@@ -116,9 +116,7 @@ class ScopedTrace;                     // Implements scoped trace.
 class TestInfoImpl;                    // Opaque implementation of TestInfo
 class TestResult;                      // Result of a single Test.
 class UnitTestImpl;                    // Opaque implementation of UnitTest
-
 template <typename E> class List;      // A generic list.
-template <typename E> class ListNode;  // A node in a generic list.
 
 // How many times InitGoogleTest() has been called.
 extern int g_init_gtest_count;

src/gtest-test-part.cc

@@ -86,12 +86,7 @@ const TestPartResult& TestPartResultArray::GetTestPartResult(int index) const {
     internal::posix::Abort();
   }
 
-  const internal::ListNode<TestPartResult>* p = list_->Head();
-  for (int i = 0; i < index; i++) {
-    p = p->next();
-  }
-
-  return p->element();
+  return list_->GetElement(index);
 }
 
 // Returns the number of TestPartResult objects in the array.

test/gtest_stress_test.cc

@@ -46,7 +46,6 @@ namespace testing {
 namespace {
 
 using internal::List;
-using internal::ListNode;
 using internal::String;
 using internal::TestProperty;
 using internal::TestPropertyKeyIs;
@@ -70,9 +69,10 @@ void ExpectKeyAndValueWereRecordedForId(const List<TestProperty>& properties,
                                         int id,
                                         const char* suffix) {
   TestPropertyKeyIs matches_key(IdToKey(id, suffix).c_str());
-  const ListNode<TestProperty>* node = properties.FindIf(matches_key);
-  EXPECT_TRUE(node != NULL) << "expecting " << suffix << " node for id " << id;
-  EXPECT_STREQ(IdToString(id).c_str(), node->element().value());
+  const TestProperty* property = properties.FindIf(matches_key);
+  ASSERT_TRUE(property != NULL)
+      << "expecting " << suffix << " value for id " << id;
+  EXPECT_STREQ(IdToString(id).c_str(), property->value());
 }
 
 // Calls a large number of Google Test assertions, where exactly one of them