Skip to content

G
googletest
Commit 7990f566 by Gregory Pakosz
Options

Re-enable MSVC++ C4389 warning in CmdHelperEq()

C4389 was inhibited in commit 4b83461e making behavior inconsistent with other compilers.
parent 0062e486
Showing with 0 additions and 2 deletions
googletest/include/gtest/gtest.h
...@@ -1386,11 +1386,9 @@ AssertionResult CmpHelperEQ(const char* lhs_expression, ...@@ -1386,11 +1386,9 @@ AssertionResult CmpHelperEQ(const char* lhs_expression,
const char* rhs_expression, const char* rhs_expression,
const T1& lhs, const T1& lhs,
const T2& rhs) { const T2& rhs) {
GTEST_DISABLE_MSC_WARNINGS_PUSH_(4389 /* signed/unsigned mismatch */)
if (lhs == rhs) { if (lhs == rhs) {
return AssertionSuccess(); return AssertionSuccess();
} }
GTEST_DISABLE_MSC_WARNINGS_POP_()
return CmpHelperEQFailure(lhs_expression, rhs_expression, lhs, rhs); return CmpHelperEQFailure(lhs_expression, rhs_expression, lhs, rhs);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment