Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
googletest
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
googletest
Commits
a3b85916
Commit
a3b85916
authored
May 31, 2012
by
zhanyong.wan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes threading annotations and compatibility with C++11, which doesn't
allow exepctions to be thrown in a destructor.
parent
cdb24f86
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
16 additions
and
10 deletions
+16
-10
gtest.cc
src/gtest.cc
+2
-2
gtest_catch_exceptions_test.py
test/gtest_catch_exceptions_test.py
+11
-8
gtest_catch_exceptions_test_.cc
test/gtest_catch_exceptions_test_.cc
+3
-0
No files found.
src/gtest.cc
View file @
a3b85916
...
@@ -3530,7 +3530,7 @@ void StreamingListener::MakeConnection() {
...
@@ -3530,7 +3530,7 @@ void StreamingListener::MakeConnection() {
// Pushes the given source file location and message onto a per-thread
// Pushes the given source file location and message onto a per-thread
// trace stack maintained by Google Test.
// trace stack maintained by Google Test.
ScopedTrace
::
ScopedTrace
(
const
char
*
file
,
int
line
,
const
Message
&
message
)
ScopedTrace
::
ScopedTrace
(
const
char
*
file
,
int
line
,
const
Message
&
message
)
GTEST_LOCK_EXCLUDED_
(
UnitTest
::
mutex_
)
{
GTEST_LOCK_EXCLUDED_
(
&
UnitTest
::
mutex_
)
{
TraceInfo
trace
;
TraceInfo
trace
;
trace
.
file
=
file
;
trace
.
file
=
file
;
trace
.
line
=
line
;
trace
.
line
=
line
;
...
@@ -3541,7 +3541,7 @@ ScopedTrace::ScopedTrace(const char* file, int line, const Message& message)
...
@@ -3541,7 +3541,7 @@ ScopedTrace::ScopedTrace(const char* file, int line, const Message& message)
// Pops the info pushed by the c'tor.
// Pops the info pushed by the c'tor.
ScopedTrace
::~
ScopedTrace
()
ScopedTrace
::~
ScopedTrace
()
GTEST_LOCK_EXCLUDED_
(
UnitTest
::
mutex_
)
{
GTEST_LOCK_EXCLUDED_
(
&
UnitTest
::
mutex_
)
{
UnitTest
::
GetInstance
()
->
PopGTestTrace
();
UnitTest
::
GetInstance
()
->
PopGTestTrace
();
}
}
...
...
test/gtest_catch_exceptions_test.py
View file @
a3b85916
...
@@ -117,14 +117,17 @@ class CatchCxxExceptionsTest(gtest_test_utils.TestCase):
...
@@ -117,14 +117,17 @@ class CatchCxxExceptionsTest(gtest_test_utils.TestCase):
'"CxxExceptionInConstructorTest" (no quotes) '
'"CxxExceptionInConstructorTest" (no quotes) '
'appears on the same line as words "called unexpectedly"'
)
'appears on the same line as words "called unexpectedly"'
)
def
testCatchesCxxExceptionsInFixtureDestructor
(
self
):
if
(
'CxxExceptionInDestructorTest.ThrowsExceptionInDestructor'
in
self
.
assert_
(
'C++ exception with description '
EX_BINARY_OUTPUT
):
'"Standard C++ exception" thrown '
'in the test fixture
\'
s destructor'
def
testCatchesCxxExceptionsInFixtureDestructor
(
self
):
in
EX_BINARY_OUTPUT
)
self
.
assert_
(
'C++ exception with description '
self
.
assert_
(
'CxxExceptionInDestructorTest::TearDownTestCase() '
'"Standard C++ exception" thrown '
'called as expected.'
'in the test fixture
\'
s destructor'
in
EX_BINARY_OUTPUT
)
in
EX_BINARY_OUTPUT
)
self
.
assert_
(
'CxxExceptionInDestructorTest::TearDownTestCase() '
'called as expected.'
in
EX_BINARY_OUTPUT
)
def
testCatchesCxxExceptionsInSetUpTestCase
(
self
):
def
testCatchesCxxExceptionsInSetUpTestCase
(
self
):
self
.
assert_
(
'C++ exception with description "Standard C++ exception"'
self
.
assert_
(
'C++ exception with description "Standard C++ exception"'
...
...
test/gtest_catch_exceptions_test_.cc
View file @
a3b85916
...
@@ -137,6 +137,8 @@ TEST_F(CxxExceptionInConstructorTest, ThrowsExceptionInConstructor) {
...
@@ -137,6 +137,8 @@ TEST_F(CxxExceptionInConstructorTest, ThrowsExceptionInConstructor) {
<<
"called unexpectedly."
;
<<
"called unexpectedly."
;
}
}
// Exceptions in destructors are not supported in C++11.
#if !defined(__GXX_EXPERIMENTAL_CXX0X__) && __cplusplus < 201103L
class
CxxExceptionInDestructorTest
:
public
Test
{
class
CxxExceptionInDestructorTest
:
public
Test
{
public
:
public
:
static
void
TearDownTestCase
()
{
static
void
TearDownTestCase
()
{
...
@@ -153,6 +155,7 @@ class CxxExceptionInDestructorTest : public Test {
...
@@ -153,6 +155,7 @@ class CxxExceptionInDestructorTest : public Test {
};
};
TEST_F
(
CxxExceptionInDestructorTest
,
ThrowsExceptionInDestructor
)
{}
TEST_F
(
CxxExceptionInDestructorTest
,
ThrowsExceptionInDestructor
)
{}
#endif // C++11 mode
class
CxxExceptionInSetUpTestCaseTest
:
public
Test
{
class
CxxExceptionInSetUpTestCaseTest
:
public
Test
{
public
:
public
:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment