Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
googletest
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
googletest
Commits
bbf738a2
Commit
bbf738a2
authored
Aug 14, 2018
by
Gennadiy Civil
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
more comments changes
parent
265efde9
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
4 additions
and
4 deletions
+4
-4
gmock-spec-builders.cc
googlemock/src/gmock-spec-builders.cc
+1
-1
gmock.cc
googlemock/src/gmock.cc
+1
-1
googletest-options-test.cc
googletest/test/googletest-options-test.cc
+1
-1
gtest_repeat_test.cc
googletest/test/gtest_repeat_test.cc
+1
-1
No files found.
googlemock/src/gmock-spec-builders.cc
View file @
bbf738a2
...
@@ -606,7 +606,7 @@ class MockObjectRegistry {
...
@@ -606,7 +606,7 @@ class MockObjectRegistry {
if
(
it
->
second
.
leakable
)
// The user said it's fine to leak this object.
if
(
it
->
second
.
leakable
)
// The user said it's fine to leak this object.
continue
;
continue
;
//
TODO(wan@google.com)
: Print the type of the leaked object.
//
FIXME
: Print the type of the leaked object.
// This can help the user identify the leaked object.
// This can help the user identify the leaked object.
std
::
cout
<<
"
\n
"
;
std
::
cout
<<
"
\n
"
;
const
MockObjectState
&
state
=
it
->
second
;
const
MockObjectState
&
state
=
it
->
second
;
...
...
googlemock/src/gmock.cc
View file @
bbf738a2
...
@@ -33,7 +33,7 @@
...
@@ -33,7 +33,7 @@
namespace
testing
{
namespace
testing
{
//
TODO(wan@google.com)
: support using environment variables to
//
FIXME
: support using environment variables to
// control the flag values, like what Google Test does.
// control the flag values, like what Google Test does.
GMOCK_DEFINE_bool_
(
catch_leaked_mocks
,
true
,
GMOCK_DEFINE_bool_
(
catch_leaked_mocks
,
true
,
...
...
googletest/test/googletest-options-test.cc
View file @
bbf738a2
...
@@ -106,7 +106,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) {
...
@@ -106,7 +106,7 @@ TEST(OutputFileHelpersTest, GetCurrentExecutableName) {
const
bool
success
=
exe_str
==
"app"
;
const
bool
success
=
exe_str
==
"app"
;
#else
#else
// FIXME: remove the hard-coded "lt-" prefix when
// FIXME: remove the hard-coded "lt-" prefix when
//
Chandler Carruth's
libtool replacement is ready.
// libtool replacement is ready.
const
bool
success
=
const
bool
success
=
exe_str
==
"googletest-options-test"
||
exe_str
==
"googletest-options-test"
||
exe_str
==
"gtest_all_test"
||
exe_str
==
"gtest_all_test"
||
...
...
googletest/test/gtest_repeat_test.cc
View file @
bbf738a2
...
@@ -118,7 +118,7 @@ class MyParamTest : public testing::TestWithParam<int> {};
...
@@ -118,7 +118,7 @@ class MyParamTest : public testing::TestWithParam<int> {};
TEST_P
(
MyParamTest
,
ShouldPass
)
{
TEST_P
(
MyParamTest
,
ShouldPass
)
{
// FIXME: Make parameter value checking robust
// FIXME: Make parameter value checking robust
//
WRT order of tests.
// WRT order of tests.
GTEST_CHECK_INT_EQ_
(
g_param_test_count
%
kNumberOfParamTests
,
GetParam
());
GTEST_CHECK_INT_EQ_
(
g_param_test_count
%
kNumberOfParamTests
,
GetParam
());
g_param_test_count
++
;
g_param_test_count
++
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment