1. 24 Mar, 2020 2 commits
  2. 21 Mar, 2020 2 commits
  3. 18 Mar, 2020 2 commits
  4. 17 Mar, 2020 8 commits
  5. 11 Mar, 2020 1 commit
    • Make sure IsATTY does not clobber errno. · a1b0173d
      Romain Geissler authored
      Exposition of the problem:
      > cat main.cpp
      
      TEST(errnoTest, errnoTest)
      {
          ASSERT_EQ(errno, 0);
      }
      
      int main(int argc, char** argv)
      {
          ::testing::InitGoogleTest(&argc, argv);
      
          return RUN_ALL_TESTS();
      }
      
      Compiled with gcc 10 like this:
      > g++ -pthread -o runtest main.cpp -Wl,-Bstatic -lgtest -Wl,-Bdynamic
      
      Before patch:
      >  ./runtest
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
      
      (output is colored, I run this inside an interactive terminal).
      
      > ./runtest | cat
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      main.cpp:5: Failure
      Expected equality of these values:
        (*__errno_location ())
          Which is: 25
        0
      [  FAILED  ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 0 tests.
      [  FAILED  ] 1 test, listed below:
      [  FAILED  ] errnoTest.errnoTest
      
       1 FAILED TEST
      
      (output is not colored, since IsTTY return false, because of the pipe,
      however it also clobbered errno for the tests).
      
      After the patch, both cases are working fine:
      > ./runtest
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
      
      > ./runtest | cat
      [==========] Running 1 test from 1 test suite.
      [----------] Global test environment set-up.
      [----------] 1 test from errnoTest
      [ RUN      ] errnoTest.errnoTest
      [       OK ] errnoTest.errnoTest (0 ms)
      [----------] 1 test from errnoTest (0 ms total)
      
      [----------] Global test environment tear-down
      [==========] 1 test from 1 test suite ran. (0 ms total)
      [  PASSED  ] 1 test.
  6. 28 Feb, 2020 3 commits
    • Googletest export · e588eb1f
      Abseil Team authored
      Rename internal color enumerators to avoid conflicts with curses.h macro definitions.
      Fixes #2685
      
      PiperOrigin-RevId: 297639382
    • Googletest export · 909b1ccf
      Abseil Team authored
      Relax the implementation of MatcherCast to allow conversion of `Matcher<T>` to
      `Matcher<const T&>`. They have the same match signature.
      
      PiperOrigin-RevId: 297115843
    • Googletest export · fd538161
      Abseil Team authored
      Allow construction of an Action from a callable of zero args
      
      Action already allows construction from a callable with the same args as the mocked function, without needing to wrap the callable in Invoke. However, if you don't care about the arguments to the mocked function you need to either accept all of them or wrap your callable in InvokeWithoutArgs. This change makes both of those unnecessary, since it allows you to pass a no-args callable to Action directly.
      
      PiperOrigin-RevId: 296117034
  7. 21 Feb, 2020 1 commit
  8. 13 Feb, 2020 1 commit
    • Googletest export · 23b2a3b1
      Abseil Team authored
      Remove the CMAKE_CXX_STANDARD from GoogleTest's CMakeLists.txt
      
      This causes ABI issues since it can create a mixed-mode build.  The
      value should be inherited from the top-level build if it needs to be
      set.
      
      PiperOrigin-RevId: 294730724
  9. 11 Feb, 2020 5 commits
    • Googletest export · 6f5fd0d7
      Abseil Team authored
      Add gmock Matcher<std::string_view> specialization.
      
      PiperOrigin-RevId: 294443240
    • Googletest export · d0930731
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.  Fix several
      related bugs in argument parsing and return types.
      - handle commas more correctly in return types
      - handle commas correctly in arguments
      - handle default values more correctly
      
      PiperOrigin-RevId: 294435093
    • Googletest export · 56de7cc8
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294360947
    • Googletest export · 360f5f70
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294332975
    • Googletest export · 139fa202
      Abseil Team authored
      Refactor function GetNextPrime so that the loop precondition is checked before
      loop instead of during every loop run.  Also by removing the loop condition,
      it shows that the only exit from the loop is the return statement.
      
      PiperOrigin-RevId: 293932783
  10. 07 Feb, 2020 15 commits
    • Googletest export · 41b5f149
      Abseil Team authored
      Get rid of gmock-generated-matchers.h and gmock-generated-matchers.h.pump.
      
      Stop using pump for MATCHER* macroses generation.
      
      PiperOrigin-RevId: 293878808
    • Googletest export · 2d6d7a01
      durandal authored
      Tag the function generated by MATCHER with GTEST_ATTRIBUTE_UNUSED_ to fix CI builds of gmock-matchers_test.cc vs. -Wunused-function.
      
      See https://github.com/google/googletest/pull/2697 for breakage.
      
      PiperOrigin-RevId: 293669752
    • Googletest export · fbf67a70
      Abseil Team authored
      Get rid of gmock-generated-function-mockers.h and
      gmock-generated-function-mockers.h.pump.
      
      Stop using pump for GMOCK_METHOD* macroses generation.
      
      PiperOrigin-RevId: 293454519
    • Googletest export · 11d9834e
      Abseil Team authored
      ...text exposed to GitHub repo https://www.github.com/google/googletest
      
      PiperOrigin-RevId: 293438092
    • Googletest export · d02e2772
      Abseil Team authored
      Pass method's parameters count to internal GMOCK_METHOD* macro.
      
      This will help removing copypaste in every GMOCK_METHOD* macro in future.
      
      PiperOrigin-RevId: 292932554
    • Googletest export · 4f660912
      Abseil Team authored
      Fix std::move to std::forward where appropriate to support reference types.
      
      PiperOrigin-RevId: 292923058
    • Googletest export · 74b44b2d
      Abseil Team authored
      Disable warning C4800 for Visual Studio 2019.
      
      The compiler warning C4800 is disabled by default in Visual Studio 2019,
      but it can be enabled on the command line. The only version of
      Visual Studio that does not support warning C4800 is Visual Studio 2017.
      
      PiperOrigin-RevId: 292624510
    • Googletest export · 572e261b
      Abseil Team authored
      Fix use of reserved names.
      Minimize code duplication needed for explict-vs-nonexplicit constructor.
      
      PiperOrigin-RevId: 292555014
    • Googletest export · 7bc671b8
      Abseil Team authored
      Add documentation for ASSERT_DEBUG_DEATH/EXPECT_DEBUG_DEATH
      
      PiperOrigin-RevId: 292138974
    • Googletest export · 38f6608e
      Abseil Team authored
      Add includes for type_traits and utility to gmock-function-mocker.h: macros in the file require these headers.
      
      PiperOrigin-RevId: 291782497
    • Googletest export · d6ce39ed
      Abseil Team authored
      Create implementation macroses for matchers to move variadic parameters to the
      end of parameters list.
      
      To save backward compatibility, old macroses will be still taking `description`
      parameter as the last one. But they will use INTERNAL macro that takes
      `description` as the second parameter.
      
      PiperOrigin-RevId: 291724469
    • Googletest export · 7413280c
      Abseil Team authored
      Adds missing `#define` guard around `TEST_F(...)`
      
      PiperOrigin-RevId: 291703056
    • Googletest export · 87061810
      Abseil Team authored
      Move part of functionality of Matcher* class to the base one. Reduce copypaste.
      
      Make constructor and conversion operator of Matcher* class independent of pump.
      
      PiperOrigin-RevId: 291405510
    • Googletest export · f1a6db9d
      Abseil Team authored
      Deleted an orphaned duplicate file and exclude another that shouldn't be part of :gtest_all_test.
      
      This showed up while trying to debug the presubmit failure for: https://github.com/google/googletest/pull/2683
      
      PiperOrigin-RevId: 291398123
    • Googletest export · 22397f28
      Abseil Team authored
      Add missing explicit keyword for gmock_Impl constructor.
      
      When switching to using GMOCK_PP in ACTION* macroses `explicit` keyword was
      missed in gmock_Impl constructor causing ClangTidy warnings in ACTION_P macro.
      
      PiperOrigin-RevId: 291159975