1. 13 May, 2020 1 commit
  2. 07 May, 2020 1 commit
    • Googletest export · a09ea700
      Abseil Team authored
      Fix `-Wgnu-zero-variadic-macro-arguments` in GMock
      
      Passing zero arguments to the variadic part of a macro is a GNU
      extension and triggers warnings when build projects using GMock with
      `-pedantic`.
      
       - Fix uses of `GMOCK_PP_INTERNAL_16TH` to always receive at least 17
      arguments. (this was triggered when `GMOCK_PP_NARG` or `GMOCK_PP_HAS_COMMA`
      were used with an argument containing no commas).
       - Fix `GMOCK_PP_HEAD` to append a dummy unused argument so that
      `GMOCK_PP_INTERNAL_HEAD` always has two arguments.
      
      PiperOrigin-RevId: 310414611
  3. 05 May, 2020 3 commits
  4. 01 May, 2020 13 commits
    • Googletest export · 0eea2e9f
      Abseil Team authored
      Fix documentation. This address https://github.com/google/googletest/pull/2827.
      
      PiperOrigin-RevId: 309241571
    • Googletest export · 3cfb4117
      Abseil Team authored
      Fix link to "high-perf dependency injection technique".
      
      PiperOrigin-RevId: 308893893
    • Merge pull request #2818 from inazarenko:master · 472cd8fd
      Gennadiy Rozental authored
      PiperOrigin-RevId: 308711492
    • Merge pull request #2818 from inazarenko:master · b99b421d
      Gennadiy Rozental authored
      PiperOrigin-RevId: 308650221
    • Googletest export · 12932978
      Abseil Team authored
      internal change
      
      PiperOrigin-RevId: 308648034
    • Merge pull request #2815 from Quuxplusone:simple · ef25d27d
      Gennadiy Rozental authored
      PiperOrigin-RevId: 308625388
    • Googletest export · 95555251
      Abseil Team authored
      Rewrite ReturnNew action without using pump.
      
      PiperOrigin-RevId: 308219616
    • Googletest export · d7ca9af0
      Abseil Team authored
      Use InitGoogleTest() instead of InitGoogle() in code example
      
      PiperOrigin-RevId: 308070819
    • Merge pull request #2797 from Jyun-Neng:master · b0e53e2d
      Gennadiy Rozental authored
      PiperOrigin-RevId: 307604377
    • Googletest export · 1b3eb6ef
      Abseil Team authored
      Explicitly define copy constructors used in googletest tests
      
      As of C++11, providing a user-declared copy assignment operator should
      suppress the availability of an implicit default copy constructor.
      Classes that provide (or delete) a copy assignment operator must provide
      their own copy constructor if one is desired. This may be an explicit
      default copy constructor if appropriate.
      
      As googletest is a C++11 codebase, this change should be made without
      qualification.
      
      This addresses the -Wdeprecated-copy warnings issued by trunk clang:
      
      While compiling googletest/test/googletest-death-test-test.cc:
      
      In file included from .../googletest/test/googletest-death-test-test.cc:33:
      .../googletest/include/gtest/gtest-death-test.h:196:8: error: definition of implicit copy constructor for 'ExitedWithCode' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
        void operator=(const ExitedWithCode& other);
             ^
      .../googletest/test/googletest-death-test-test.cc:279:16: note: in implicit copy constructor for 'testing::ExitedWithCode' first required here
        EXPECT_PRED1(pred0,  status0);
                     ^
      
      While compiling googletest/test/googletest-param-test-test.cc:
      
      .../googletest/test/googletest-param-test-test.cc:502:8: error: definition of implicit copy constructor for 'NonDefaultConstructAssignString' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
        void operator=(const NonDefaultConstructAssignString&);
             ^
      .../googletest/test/googletest-param-test-test.cc:507:36: note: in implicit copy constructor for 'NonDefaultConstructAssignString' first required here
            Combine(Values(0, 1), Values(NonDefaultConstructAssignString("A"),
      
      This matches other changes made elsewhere in the googletest codebase,
      such as 306f3754. Perhaps those previous changes did not consider
      test code.
      
      PiperOrigin-RevId: 307495126
    • Googletest export · fb5d9b66
      Abseil Team authored
      Fix comment that describes how to test against nullopt.
      
      PiperOrigin-RevId: 307448375
    • Googletest export · a6770105
      Abseil Team authored
      Internal change
      
      PiperOrigin-RevId: 307040308
    • Removed a typo in README.md · 4bab55dc
      keshavgbpecdelhi authored
      There is an unnecessary comma before 'and'
  5. 24 Apr, 2020 5 commits
    • Fix a -Wdeprecated warning. · c7d8ec72
      Arthur O'Dwyer authored
          googletest-param-test-test.cc:502:8: error:
          definition of implicit copy constructor for
          'NonDefaultConstructAssignString' is deprecated because it has a
          user-declared copy assignment operator [-Werror,-Wdeprecated]
              void operator=(const NonDefaultConstructAssignString&);
                   ^
    • Fix a -Wdeprecated warning. · 01c0ff5e
      Arthur O'Dwyer authored
          googletest-port-test.cc:97:11: error:
          definition of implicit copy constructor for 'Base' is deprecated because
          it has a user-declared destructor [-Werror,-Wdeprecated]
              virtual ~Base() {}
                      ^
    • Fix a -Wdeprecated warning. · 11b3cec1
      Arthur O'Dwyer authored
          gmock-spec-builders.h:503:3: error:
          definition of implicit copy constructor for 'Expectation' is deprecated
          because it has a user-declared destructor [-Werror,-Wdeprecated]
              ~Expectation();
              ^
    • Remove all uses of GTEST_DISALLOW_{MOVE_,}ASSIGN_. · 766ac2e1
      Arthur O'Dwyer authored
      None of these are strictly needed for correctness.
      A large number of them (maybe all of them?) trigger `-Wdeprecated`
      warnings on Clang trunk as soon as you try to use the implicitly
      defaulted (but deprecated) copy constructor of a class that has
      deleted its copy assignment operator.
      
      By declaring a deleted copy assignment operator, the old code
      also caused the move constructor and move assignment operator
      to be non-declared. This means that the old code never got move
      semantics -- "move-construction" would simply call the defaulted
      (but deprecated) copy constructor instead. With the new code,
      "move-construction" calls the defaulted move constructor, which
      I believe is what we want to happen. So this is a runtime
      performance optimization.
      
      Unfortunately we can't yet physically remove the definitions
      of these macros from gtest-port.h, because they are being used
      by other code internally at Google (according to zhangxy988).
      But no new uses should be added going forward.
  6. 20 Apr, 2020 1 commit
  7. 16 Apr, 2020 8 commits
    • VariadicMatcher needs a non-defaulted move constructor for compile-time performance. · 4f002f1e
      Arthur O'Dwyer authored
      We are about to remove all uses of GTEST_DISALLOW_ASSIGN_ in favor
      of using the Rule of Zero everywhere.
      
      Unfortunately, if we use the Rule of Zero here, then when the compiler
      needs to figure out if VariadicMatcher is move-constructible, it will
      recurse down into `tuple<Args...>`, which on libstdc++ recurses too deeply.
      
          In file included from googlemock/test/gmock-matchers_test.cc:43:
          In file included from googlemock/include/gmock/gmock-matchers.h:258:
          In file included from /usr/include/c++/5.5.0/algorithm:60:
          In file included from /usr/include/c++/5.5.0/utility:70:
          In file included from /usr/include/c++/5.5.0/bits/stl_pair.h:59:
          In file included from /usr/include/c++/5.5.0/bits/move.h:57:
          /usr/bin/include/c++/5.5.0/type_traits:115:26: fatal error:
                recursive template instantiation exceeded maximum depth of 256
              : public conditional<_B1::value, _B1, _B2>::type
                                   ^
      
      The move constructor is the only problematic case, for some unknown reason.
      With GTEST_DISALLOW_ASSIGN_, the presence of a copy assignment operator
      causes the move constructor to be non-declared, thus non-defaulted, thus
      non-problematic. Without GTEST_DISALLOW_ASSIGN_, we have to do one of the
      following:
      
      - Default the copy constructor, so that the move constructor will be non-declared.
      
      - Define our own non-defaulted move constructor.
      
      ...except that doing the latter STILL did not work!
      Fortunately, the former (default the copy constructor, don't provide
      any move constructor) both works in practice and is semantically
      equivalent to the old code.
    • Merge pull request #2805 from pepsiman:patch-1 · dcc92d0a
      Mark Barolak authored
      PiperOrigin-RevId: 306462650
    • Merge pull request #2802 from e-i-n-s:fix_clang_warning · 71d5df6c
      Mark Barolak authored
      PiperOrigin-RevId: 306460942
    • Merge pull request #2810 from ptahmose:master · 4c8e6a9f
      Mark Barolak authored
      PiperOrigin-RevId: 306460738
    • Googletest export · 373d72b6
      Abseil Team authored
      Fix link to "After clause". Sorry, reader, but this heading is in another document!
      
      PiperOrigin-RevId: 305947971
    • Merge pull request #2756 from Conan-Kudo:fix-pkgconfig-reqs · 4fe5ac53
      Mark Barolak authored
      PiperOrigin-RevId: 305747437
    • Merge pull request #2772 from Quuxplusone:travis · c2032090
      Mark Barolak authored
      PiperOrigin-RevId: 305747317
    • Merge pull request #2773 from Quuxplusone:replace-noexcept · b51a49e0
      Mark Barolak authored
      PiperOrigin-RevId: 305707266
  8. 12 Apr, 2020 1 commit
  9. 09 Apr, 2020 1 commit
  10. 07 Apr, 2020 1 commit
  11. 04 Apr, 2020 4 commits
  12. 31 Mar, 2020 1 commit
    • Googletest export · 61f010d7
      Abseil Team authored
      Do not use std::result_of as it was removed in C++20.
      
      PiperOrigin-RevId: 303783600