🔨 small refactoring

The solution with a std::runtime_error member is more elegant. It allows to have std::exception as base class again. However, I still have no idea why GCC thinks the copy constructor may throw...

🔨 small refactoring
c333679a · Niels Lohmann · cc36c65a · c333679a · c333679a
Unverified Commit c333679a authored Mar 25, 2017 by Niels Lohmann
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 6 deletions

json.hpp src/json.hpp +6 -3

json.hpp.re2c src/json.hpp.re2c +6 -3

No files found.
--- a/src/json.hpp
+++ b/src/json.hpp
@@ -123,13 +123,13 @@ Extension of std::exception objects with a member @a id for exception ids.

 @since version 3.0.0
 */
-class exception : public std::runtime_error
+class exception : public std::exception
 {
  public:
    /// returns the explanatory string
    virtual const char* what() const noexcept override
    {
-        return std::runtime_error::what();
+        return m.what();
    }

    /// the id of the exception
@@ -137,13 +137,16 @@ class exception : public std::runtime_error

  protected:
    exception(int id_, const char* what_arg)
-        : std::runtime_error(what_arg), id(id_)
+        : id(id_), m(what_arg)
    {}

    static std::string name(const std::string& ename, int id_)
    {
        return "[json.exception." + ename + "." + std::to_string(id_) + "] ";
    }
+
+  private:
+    std::runtime_error m;
 };

 /*!

--- a/src/json.hpp.re2c
+++ b/src/json.hpp.re2c
@@ -123,13 +123,13 @@ Extension of std::exception objects with a member @a id for exception ids.

 @since version 3.0.0
 */
-class exception : public std::runtime_error
+class exception : public std::exception
 {
  public:
    /// returns the explanatory string
    virtual const char* what() const noexcept override
    {
-        return std::runtime_error::what();
+        return m.what();
    }

    /// the id of the exception
@@ -137,13 +137,16 @@ class exception : public std::runtime_error

  protected:
    exception(int id_, const char* what_arg)
-        : std::runtime_error(what_arg), id(id_)
+        : id(id_), m(what_arg)
    {}

    static std::string name(const std::string& ename, int id_)
    {
        return "[json.exception." + ename + "." + std::to_string(id_) + "] ";
    }
+
+  private:
+    std::runtime_error m;
 };

 /*!