fortify: check the value returned from write(2)

Also check that we wrote the amount we expected to. The write on the pty is blocking but we could still get a short write on EINTR, so we should SYSERROR it. Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

fortify: check the value returned from write(2)
0a218854 · Dwight Engen · Stéphane Graber · 03027ad9 · 0a218854
Commit 0a218854 authored Apr 15, 2013 by Dwight Engen Committed by Stéphane Graber Apr 16, 2013
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

lxc_console.c src/lxc/lxc_console.c +6 -2

No files found.
--- a/src/lxc/lxc_console.c
+++ b/src/lxc/lxc_console.c
@@ -165,14 +165,18 @@ static int master_handler(int fd, void *data, struct lxc_epoll_descr *descr)
 {
 	char buf[1024];
 	int *peer = (int *)data;
-	int r;
+	int r,w;

 	r = read(fd, buf, sizeof(buf));
 	if (r < 0) {
 		SYSERROR("failed to read");
 		return 1;
 	}
-	r = write(*peer, buf, r);
+	w = write(*peer, buf, r);
+	if (w < 0 || w != r) {
+		SYSERROR("failed to write");
+		return 1;
+	}

 	return 0;
 }