lxcapi_clone: exit early on snapshot clones

If the user explicitly asks for a snapshot clone (in which case maybe_snap is not set), we cannot abide this currently. Rather than exit later with more cryptic error messages, exit out early. Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com> Acked-by: Stéphane Graber <stgraber@ubuntu.com>

lxcapi_clone: exit early on snapshot clones
0bc8db6b · Serge Hallyn · Stéphane Graber · 691ac4a3 · 0bc8db6b
Commit 0bc8db6b authored Jan 25, 2014 by Serge Hallyn Committed by Stéphane Graber Jan 25, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

bdev.c src/lxc/bdev.c +5 -0

No files found.
--- a/src/lxc/bdev.c
+++ b/src/lxc/bdev.c
@@ -2101,6 +2101,11 @@ struct bdev *bdev_copy(struct lxc_container *c0, const char *cname,

 	/* check for privilege */
 	if (am_unpriv()) {
+		if (snap && !maybe_snap) {
+			ERROR("Unprivileged users cannot snapshot");
+			bdev_put(orig);
+			return NULL;
+		}
 		if (bdevtype && strcmp(bdevtype, "dir") != 0) {
 			ERROR("Unprivileged users can only make dir copy-clones");
 			bdev_put(orig);