attach: don't return early when calculating namespaces via pidfd

parent c0f1dc95
...@@ -534,9 +534,6 @@ static int __prepare_namespaces_pidfd(struct attach_context *ctx) ...@@ -534,9 +534,6 @@ static int __prepare_namespaces_pidfd(struct attach_context *ctx)
for (int i = 0; i < LXC_NS_MAX; i++) { for (int i = 0; i < LXC_NS_MAX; i++) {
int ret; int ret;
if (!(ctx->ns_inherited & ns_info[i].clone_flag))
continue;
ret = same_nsfd(ctx->dfd_self_pid, ret = same_nsfd(ctx->dfd_self_pid,
ctx->dfd_init_pid, ctx->dfd_init_pid,
ns_info[i].proc_path); ns_info[i].proc_path);
...@@ -545,10 +542,11 @@ static int __prepare_namespaces_pidfd(struct attach_context *ctx) ...@@ -545,10 +542,11 @@ static int __prepare_namespaces_pidfd(struct attach_context *ctx)
__fallthrough; __fallthrough;
case 1: case 1:
ctx->ns_inherited &= ~ns_info[i].clone_flag; ctx->ns_inherited &= ~ns_info[i].clone_flag;
break; TRACE("Shared %s namespace doesn't need attach", ns_info[i].proc_name);
continue;
case 0: case 0:
TRACE("Shared %s namespace needs attach", ns_info[i].proc_name); TRACE("Different %s namespace needs attach", ns_info[i].proc_name);
break; continue;
} }
return syserror("Failed to determine whether %s namespace is shared", return syserror("Failed to determine whether %s namespace is shared",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment