lxccontainer: avoid NULL pointer dereference

In case the lxc command socket is hashed and the socket was created for a different path than the one we're currently querying lxc_cmd_get_{lxcpath,name}() can return NULL. The command socket path is hashed when len(lxcpath) > sizeof(sun_path) - 2. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

lxccontainer: avoid NULL pointer dereference
107fd8bf · Christian Brauner · Stéphane Graber · 62053667 · 107fd8bf
Unverified Commit 107fd8bf authored May 06, 2017 by Christian Brauner Committed by Stéphane Graber May 09, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

lxccontainer.c src/lxc/lxccontainer.c +4 -1

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -3584,7 +3584,10 @@ int list_active_containers(const char *lxcpath, char ***nret,
 		*p2 = '\0';

 		if (is_hashed) {
-			if (strncmp(lxcpath, lxc_cmd_get_lxcpath(p), lxcpath_len) != 0)
+			char *recvpath = lxc_cmd_get_lxcpath(p);
+			if (!recvpath)
+				continue;
+			if (strncmp(lxcpath, recvpath, lxcpath_len) != 0)
 				continue;
 			p = lxc_cmd_get_name(p);
 		}