network: fix socket handle leak

Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>

network: fix socket handle leak
1322cb60 · Donghwa Jeong · Christian Brauner · 1bd237a6 · 1322cb60
Unverified Commit 1322cb60 authored May 28, 2018 by Donghwa Jeong Committed by Christian Brauner Dec 10, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

network.c src/lxc/network.c +6 -1

No files found.
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -1946,7 +1946,12 @@ int setup_private_host_hw_addr(char *veth1)
 	if (sockfd < 0)
 		return -errno;

-	snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1);
+	err = snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1);
+	if (err < 0 || (size_t)err >= IFNAMSIZ) {
+		close(sockfd);
+		return -E2BIG;
+	}
+
 	err = ioctl(sockfd, SIOCGIFHWADDR, &ifr);
 	if (err < 0) {
 		close(sockfd);