Commit 13d8bde9 by Seth Robertson Committed by Serge Hallyn

lxc_unshare -u argument useful even with USER namespace shared

parent 00fe5e1d
......@@ -51,7 +51,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
<cmdsynopsis>
<command>lxc-unshare</command>
<arg choice="req">-s <replaceable>namespaces</replaceable></arg>
<arg choice="req">-u <replaceable>user</replaceable></arg>
<arg choice="opt">-u <replaceable>user</replaceable></arg>
<arg choice="req">command</arg>
</cmdsynopsis>
</refsynopsisdiv>
......@@ -100,8 +100,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
</term>
<listitem>
<para>
Specify a user which the new task should become. This option is
only valid if a user namespace is unshared.
Specify a userid which the new task should become.
</para>
</listitem>
</varlistentry>
......
......@@ -97,7 +97,8 @@ static int do_start(void *arg)
int flags = *start_arg->flags;
uid_t uid = *start_arg->uid;
if (flags & CLONE_NEWUSER && setuid(uid)) {
// Setuid is useful even without a new user id space
if ( uid >= 0 && setuid(uid)) {
ERROR("failed to set uid %d: %s", uid, strerror(errno));
exit(1);
}
......@@ -153,8 +154,6 @@ int main(int argc, char *argv[])
if (ret)
usage(argv[0]);
if (!(flags & CLONE_NEWUSER) && uid != -1) {
ERROR("-u <uid> needs -s USER option");
return 1;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment