Skip to content

L
lxc
Unverified Commit 177458b6 by Christian Brauner
Options

attach: switch to simple mount()

At the point where we're remounging proc and sys we're in the container's namespaces so there's no chance of escape so a simple mount() syscall will suffice. Signed-off-by: 's avatarChristian Brauner <christian.brauner@ubuntu.com>
parent 20af37f7
Showing with 2 additions and 2 deletions
src/lxc/attach.c
...@@ -734,7 +734,7 @@ int lxc_attach_remount_sys_proc(void) ...@@ -734,7 +734,7 @@ int lxc_attach_remount_sys_proc(void)
if (ret < 0) if (ret < 0)
return log_error_errno(-1, errno, "Failed to unmount /proc"); return log_error_errno(-1, errno, "Failed to unmount /proc");
ret = mount_filesystem("proc", "/proc", 0); ret = mount("none", "/proc", "proc", 0, NULL);
if (ret < 0) if (ret < 0)
return log_error_errno(-1, errno, "Failed to remount /proc"); return log_error_errno(-1, errno, "Failed to remount /proc");
...@@ -747,7 +747,7 @@ int lxc_attach_remount_sys_proc(void) ...@@ -747,7 +747,7 @@ int lxc_attach_remount_sys_proc(void)
return log_error_errno(-1, errno, "Failed to unmount /sys"); return log_error_errno(-1, errno, "Failed to unmount /sys");
/* Remount it. */ /* Remount it. */
if (ret == 0 && mount_filesystem("sysfs", "/sys", 0)) if (ret == 0 && mount("none", "/sys", "sysfs", 0, NULL))
return log_error_errno(-1, errno, "Failed to remount /sys"); return log_error_errno(-1, errno, "Failed to remount /sys");
return 0; return 0;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment