tools: block using lxc-execute without config file

Moving away from internal symbols we can't do hacks like we currently do in lxc-start and call internal functions like lxc_conf_init(). This is unsafe anyway. Instead, we should simply error out if the user didn't give us a configuration file to use. lxc-start refuses to start in that case already. Relates to discussion in https://github.com/lxc/go-lxc/pull/96#discussion_r155075560 . Closes #2023. Reported-by: Felix Abecassis <fabecassis@nvidia.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

tools: block using lxc-execute without config file
19bfbf6e · Christian Brauner · f449521c · 19bfbf6e
Unverified Commit 19bfbf6e authored Dec 12, 2017 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

lxc_execute.c src/lxc/tools/lxc_execute.c +6 -0

No files found.
--- a/src/lxc/tools/lxc_execute.c
+++ b/src/lxc/tools/lxc_execute.c
@@ -163,6 +163,12 @@ int main(int argc, char *argv[])
 		}
 	}

+	if (!c->lxc_conf) {
+		fprintf(stderr, "Executing a container with no configuration file may crash the host\n");
+		lxc_container_put(c);
+		exit(EXIT_FAILURE);
+	}
+
 	if (my_args.argc == 0) {
 		if (!set_argv(c->lxc_conf, &my_args)) {
 			fprintf(stderr, "missing command to execute!\n");