Tear down network devices during container halt

On very busy systems, some virtual network devices won't be destroyed after a container halts. This patch uses the lxc_delete_network() method to ensure that network devices attached to the container are destroyed when the container halts. Without the patch, some virtual network devices are left over on the system and must be removed with `ip link del <device>`. This caused containers with lxc.network.veth.pair to not be able to start. For containers using randomly generated virtual network device names, the old devices will hang around on the bridge with their original MAC address. Signed-off-by: Major Hayden <major@mhtx.net>

Tear down network devices during container halt
1f9ddb78 · Major Hayden · Stéphane Graber · 3eafa2f7 · 1f9ddb78
Commit 1f9ddb78 authored Sep 02, 2015 by Major Hayden Committed by Stéphane Graber Sep 21, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

start.c src/lxc/start.c +5 -0

No files found.
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1212,7 +1212,12 @@ int __lxc_start(const char *name, struct lxc_conf *conf,
 		}
        }
+	DEBUG("Pushing physical nics back to host namespace");
 	lxc_rename_phys_nics_on_shutdown(netnsfd, handler->conf);
+	DEBUG("Tearing down virtual network devices used by container");
+	lxc_delete_network(handler);
 	if (netnsfd >= 0)
 		close(netnsfd);