lxc-info: Limit information when not running

Don't try to print the PID, IP addresses or statistics for a container that's not current running. Signed-off-by: Stéphane Graber <stgraber@ubuntu.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

lxc-info: Limit information when not running
2177dbc7 · Stéphane Graber · 7f12cae9 · 2177dbc7
Commit 2177dbc7 authored Jan 22, 2014 by Stéphane Graber
Hide whitespace changes
Inline Side-by-side

Showing with 17 additions and 15 deletions

lxc_info.c src/lxc/lxc_info.c +17 -15

No files found.
--- a/src/lxc/lxc_info.c
+++ b/src/lxc/lxc_info.c
@@ -301,23 +301,25 @@ static int print_info(const char *name, const char *lxcpath)
 		print_info_msg_str("State:", c->state(c));
 	}

-	if (pid) {
-		pid_t initpid;
+	if (c->is_running(c)) {
+		if (pid) {
+			pid_t initpid;

-		initpid = c->init_pid(c);
-		if (initpid >= 0)
-			print_info_msg_int("PID:", initpid);
-	}
+			initpid = c->init_pid(c);
+			if (initpid >= 0)
+				print_info_msg_int("PID:", initpid);
+		}

-	if (ips) {
-		char **addresses = c->get_ips(c, NULL, NULL, 0);
-		if (addresses) {
-			char *address;
-			i = 0;
-			while (addresses[i]) {
-				address = addresses[i];
-				print_info_msg_str("IP:", address);
-				i++;
+		if (ips) {
+			char **addresses = c->get_ips(c, NULL, NULL, 0);
+			if (addresses) {
+				char *address;
+				i = 0;
+				while (addresses[i]) {
+					address = addresses[i];
+					print_info_msg_str("IP:", address);
+					i++;
+				}
 			}
 		}
 	}