Commit 22038de5 by Serge Hallyn Committed by Stéphane Graber

lxc_map_ids: add a comment

Explain why we insist that root use newuidmap if it is available. Signed-off-by: 's avatarSerge Hallyn <serge.hallyn@ubuntu.com> Acked-by: 's avatarStéphane Graber <stgraber@ubuntu.com>
parent dc5518b8
...@@ -3429,6 +3429,12 @@ int lxc_map_ids(struct lxc_list *idmap, pid_t pid) ...@@ -3429,6 +3429,12 @@ int lxc_map_ids(struct lxc_list *idmap, pid_t pid)
enum idtype type; enum idtype type;
char *buf = NULL, *pos, *cmdpath = NULL; char *buf = NULL, *pos, *cmdpath = NULL;
/*
* If newuidmap exists, that is, if shadow is handing out subuid
* ranges, then insist that root also reserve ranges in subuid. This
* will protected it by preventing another user from being handed the
* range by shadow.
*/
cmdpath = on_path("newuidmap", NULL); cmdpath = on_path("newuidmap", NULL);
if (cmdpath) { if (cmdpath) {
use_shadow = 1; use_shadow = 1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment