Fixed - set PyErr when Container.__init__ fails

When container init failed for whatever reason, previously it resulted in a `SystemError: NULL result without error in PyObject_Call` This will now result in a RuntimeError with the error message previously printed to stderr. Signed-off-by: Aron Podrigal <aronp@guaranteedplus.com>

Fixed - set PyErr when Container.init fails
225ced0f · Aron Podrigal · Stéphane Graber · 2e6f9014 · 225ced0f
Commit 225ced0f authored May 01, 2016 by Aron Podrigal Committed by Stéphane Graber May 11, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

lxc.c src/python-lxc/lxc.c +3 -1

No files found.
--- a/src/python-lxc/lxc.c
+++ b/src/python-lxc/lxc.c
@@ -449,7 +449,9 @@ Container_init(Container *self, PyObject *args, PyObject *kwds)
    self->container = lxc_container_new(name, config_path);
    if (!self->container) {
        Py_XDECREF(fs_config_path);
-        fprintf(stderr, "%d: error creating container %s\n", __LINE__, name);
+
+        PyErr_Format(PyExc_RuntimeError, "%s:%s:%d: error during init for container '%s'.",
+			__FUNCTION__, __FILE__, __LINE__, name);
        return -1;
    }