Fix fd leak in lxc log

lxc_log_init will leak an fd when it is called by a long running program that may call lxc_container_new multiple times. Fix by only opening the log if it is not already open. Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

Fix fd leak in lxc log
2312f31b · Dwight Engen · Stéphane Graber · 181a9be7 · 2312f31b
Commit 2312f31b authored Nov 26, 2012 by Dwight Engen Committed by Stéphane Graber Nov 26, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

log.c src/lxc/log.c +3 -0

No files found.
--- a/src/lxc/log.c
+++ b/src/lxc/log.c
@@ -153,6 +153,9 @@ extern int lxc_log_init(const char *file, const char *priority,
 {
 	int lxc_priority = LXC_LOG_PRIORITY_ERROR;

+	if (lxc_log_fd != -1)
+		return 0;
+
 	if (priority) {
 		lxc_priority = lxc_log_priority_to_int(priority);