fix lxc-info printing duplicate lines

When lxc-info's stdout is not line buffered (ie. "lxc-info -n foo |more") the first three lines will be duplicated. This is because c->get_ips() comes next and it forks and the child will exit() causing its fds to be closed which flushes out its (fork duplicated) stdio buffers. The lines are then duplicated when the parent actually gets around to flushing out its stdio. This causes problems for programs (such as the lxc-webpanel) which are popen()ing lxc-info. The fix here isn't necessarily the right one, but does show what the problem is. Seems like maybe we should fix this inside of get_ips(), for other API callers as well. Signed-off-by: Dwight Engen <dwight.engen@oracle.com> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

fix lxc-info printing duplicate lines
26d6d1c5 · Dwight Engen · Stéphane Graber · 24073c8f · 26d6d1c5
Commit 26d6d1c5 authored Apr 02, 2014 by Dwight Engen Committed by Stéphane Graber Apr 04, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

lxc_info.c src/lxc/lxc_info.c +1 -0

No files found.
--- a/src/lxc/lxc_info.c
+++ b/src/lxc/lxc_info.c
@@ -313,6 +313,7 @@ static int print_info(const char *name, const char *lxcpath)
 		}

 		if (ips) {
+			fflush(stdout);
 			char **addresses = c->get_ips(c, NULL, NULL, 0);
 			if (addresses) {
 				char *address;