Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
L
lxc
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Chen Yisong
lxc
Commits
3026aae6
Commit
3026aae6
authored
Dec 10, 2016
by
Wolfgang Bumiller
Committed by
Stéphane Graber
Dec 15, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
conf, attach: save errno across call to close
Save errno across some calls to close() since it can be interrupted. Signed-off-by:
Wolfgang Bumiller
<
wry.git@bumiller.com
>
parent
bc84967f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
6 deletions
+10
-6
attach.c
src/lxc/attach.c
+3
-3
conf.c
src/lxc/conf.c
+7
-3
No files found.
src/lxc/attach.c
View file @
3026aae6
...
...
@@ -941,7 +941,7 @@ int lxc_attach(const char* name, const char* lxcpath, lxc_attach_exec_t exec_fun
/* Open LSM fd and send it to child. */
if
((
options
->
namespaces
&
CLONE_NEWNS
)
&&
(
options
->
attach_flags
&
LXC_ATTACH_LSM
)
&&
init_ctx
->
lsm_label
)
{
int
on_exec
;
int
on_exec
,
saved_errno
;
int
labelfd
=
-
1
;
on_exec
=
options
->
attach_flags
&
LXC_ATTACH_LSM_EXEC
?
1
:
0
;
/* Open fd for the LSM security module. */
...
...
@@ -951,10 +951,10 @@ int lxc_attach(const char* name, const char* lxcpath, lxc_attach_exec_t exec_fun
/* Send child fd of the LSM security module to write to. */
ret
=
lxc_abstract_unix_send_fd
(
ipc_sockets
[
0
],
labelfd
,
NULL
,
0
);
saved_errno
=
errno
;
close
(
labelfd
);
if
(
ret
<=
0
)
{
ERROR
(
"Error using IPC to send child LSM fd (4): %s."
,
strerror
(
errno
));
ERROR
(
"Intended to send file descriptor %d: %s."
,
labelfd
,
strerror
(
saved_errno
));
goto
cleanup_error
;
}
}
...
...
src/lxc/conf.c
View file @
3026aae6
...
...
@@ -2513,7 +2513,10 @@ static int setup_mount_entries(const struct lxc_rootfs *rootfs, struct lxc_list
file
=
tmpfile
();
if
(
!
file
)
{
ERROR
(
"Could not create temporary file: %s."
,
strerror
(
errno
));
int
saved_errno
=
errno
;
if
(
fd
!=
-
1
)
close
(
fd
);
ERROR
(
"Could not create mount entry file: %s."
,
strerror
(
saved_errno
));
return
-
1
;
}
...
...
@@ -2655,7 +2658,7 @@ static int setup_hw_addr(char *hwaddr, const char *ifname)
{
struct
sockaddr
sockaddr
;
struct
ifreq
ifr
;
int
ret
,
fd
;
int
ret
,
fd
,
saved_errno
;
ret
=
lxc_convert_mac
(
hwaddr
,
&
sockaddr
);
if
(
ret
)
{
...
...
@@ -2675,9 +2678,10 @@ static int setup_hw_addr(char *hwaddr, const char *ifname)
}
ret
=
ioctl
(
fd
,
SIOCSIFHWADDR
,
&
ifr
);
saved_errno
=
errno
;
close
(
fd
);
if
(
ret
)
ERROR
(
"ioctl failure : %s"
,
strerror
(
errno
));
ERROR
(
"ioctl failure : %s"
,
strerror
(
saved_
errno
));
DEBUG
(
"mac address '%s' on '%s' has been setup"
,
hwaddr
,
ifr
.
ifr_name
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment