lxcapi_get_interfaces and lxcapi_get_ips: stricter read check

Coverity warns of the danger of a short read otherwise. (Untested, but should be correct; Tossing over to you :) Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com> Cc: S.Çağlar Onur <caglar@10ur.org> Acked-by: S.Çağlar Onur <caglar@10ur.org>

lxcapi_get_interfaces and lxcapi_get_ips: stricter read check
358afd84 · Serge Hallyn · b0f0932a · 358afd84
Commit 358afd84 authored Jan 22, 2014 by Serge Hallyn
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

lxccontainer.c src/lxc/lxccontainer.c +2 -2

No files found.
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -1556,7 +1556,7 @@ static char** lxcapi_get_interfaces(struct lxc_container *c)
 	/* close the write-end of the pipe */
 	close(pipefd[1]);

-	while (read(pipefd[0], &interface, IFNAMSIZ) > 0) {
+	while (read(pipefd[0], &interface, IFNAMSIZ) == IFNAMSIZ) {
 		if (array_contains(&interfaces, interface, count))
 				continue;

@@ -1676,7 +1676,7 @@ static char** lxcapi_get_ips(struct lxc_container *c, const char* interface, con
 	/* close the write-end of the pipe */
 	close(pipefd[1]);

-	while (read(pipefd[0], &address, INET6_ADDRSTRLEN) > 0) {
+	while (read(pipefd[0], &address, INET6_ADDRSTRLEN) == INET6_ADDRSTRLEN) {
 		if(!add_to_array(&addresses, address, count))
 			ERROR("PARENT: add_to_array failed");
 		count++;