zfs: Fix return value on zfs_snapshot error

Returning -1 in a function with return type bool is the same as returning true. Change to return false to indicate error properly. Detected with cppcheck. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

zfs: Fix return value on zfs_snapshot error
3cd86139 · Rikard Falkeborn · Christian Brauner · c5e6088f · 3cd86139
Unverified Commit 3cd86139 authored May 12, 2019 by Rikard Falkeborn Committed by Christian Brauner May 18, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

zfs.c src/lxc/storage/zfs.c +1 -1

No files found.
--- a/src/lxc/storage/zfs.c
+++ b/src/lxc/storage/zfs.c
@@ -427,7 +427,7 @@ bool zfs_snapshot(struct lxc_conf *conf, struct lxc_storage *orig,
 	if (ret < 0 || ret >= PATH_MAX) {
 		ERROR("Failed to create string");
 		free(snapshot);
-		return -1;
+		return false;
 	}

 	cmd_args.dataset = lxc_storage_get_path(new->src, new->type);