string_utils: always memset buf in lxc_safe_int64_residual()

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32482Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

string_utils: always memset buf in lxc_safe_int64_residual()
3cec50fc · Christian Brauner · b4733289 · 3cec50fc
Unverified Commit 3cec50fc authored Mar 27, 2021 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

string_utils.c src/lxc/string_utils.c +3 -3

No files found.
--- a/src/lxc/string_utils.c
+++ b/src/lxc/string_utils.c
@@ -677,6 +677,8 @@ int lxc_safe_int64_residual(const char *numstr, int64_t *converted, int base, ch
 	if (!residual && residual_len != 0)
 		return ret_errno(EINVAL);

+	memset(residual, 0, residual_len);
+
 	while (isspace(*numstr))
 		numstr++;

@@ -691,10 +693,8 @@ int lxc_safe_int64_residual(const char *numstr, int64_t *converted, int base, ch
 	if (residual) {
 		size_t len = 0;

-		if (*remaining == '\0') {
-			memset(residual, 0, residual_len);
+		if (*remaining == '\0')
 			goto out;
-		}

 		len = strlen(remaining);
 		if (len >= residual_len)