coverity: #1425928

Avoid NULL-pointer dereference. Apparently monitor.{c,h} calls lxc_check_inherited() with NULL passed for the config. This isn't really a big issue since monitor.{c,h} is effectively dead for all liblxc versions that have the state client patch. Also, the patch that introduces the relevant lines into lxc_check_inherited() is only in master and yet unreleased. Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

coverity: #1425928
3ee9e4fb · Christian Brauner · e1e76423 · 3ee9e4fb
Unverified Commit 3ee9e4fb authored Dec 07, 2017 by Christian Brauner
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 6 deletions

start.c src/lxc/start.c +8 -6

No files found.
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -226,14 +226,16 @@ restart:
 			continue;
 		/* Keep state clients that wait on reboots. */
-		lxc_list_for_each(cur, &conf->state_clients) {
+		if (conf) {
-			struct lxc_state_client *client = cur->elem;
+			lxc_list_for_each(cur, &conf->state_clients) {
+				struct lxc_state_client *client = cur->elem;
-			if (client->clientfd != fd)
+				if (client->clientfd != fd)
-				continue;
+					continue;
-			matched = true;
+				matched = true;
-			break;
+				break;
+			}
 		}
 		if (matched)